scripts/slave/recipe_modules/chromium_tests/api.py - Issue 1372133003: Revert of chromium_tests: raise infra failure when no compile targets are specified (patchset #1 id:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 1372133003: Revert of chromium_tests: raise infra failure when no compile targets are specified (patchset #1 id: (Closed) Base URL: http://src.chromium.org/chrome/trunk/tools/build/

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium_tests/api.py

===================================================================

--- scripts/slave/recipe_modules/chromium_tests/api.py (revision 296915)

+++ scripts/slave/recipe_modules/chromium_tests/api.py (working copy)

@@ -447,9 +447,6 @@

isolated_targets=isolated_targets,

name='generate_build_files%s' % name_suffix)

- if not compile_targets:

- self.m.python.failing_step(

- 'compile', 'Misconfigured bot: no compile targets')

self.m.chromium.compile(compile_targets, name='compile%s' % name_suffix)

def tests_for_builder(self, mastername, buildername, update_step, master_dict,

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux.json » ('j') | no next file with comments »