Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_shared_.json

Issue 1372133003: Revert of chromium_tests: raise infra failure when no compile targets are specified (patchset #1 id: (Closed) Base URL: http://src.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_shared_.json
===================================================================
--- scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_shared_.json (revision 296915)
+++ scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_shared_.json (working copy)
@@ -164,22 +164,110 @@
"name": "clean isolated files"
},
{
+ "allow_subannotations": true,
"cmd": [
"python",
"-u",
- "import sys; sys.exit(1)"
+ "[BUILD]\\scripts\\slave\\clang_revision.py",
+ "--src-dir",
+ "[SLAVE_BUILD]\\src",
+ "--output-json",
+ "/path/to/tmp/json"
],
"cwd": "[SLAVE_BUILD]",
- "name": "compile",
+ "name": "clang_revision",
"~followup_annotations": [
- "step returned non-zero exit code: 1",
- "@@@STEP_TEXT@Misconfigured bot: no compile targets@@@",
- "@@@STEP_FAILURE@@@"
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"clang_revision\": \"123456-7\"@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@"
]
},
{
- "name": "$final_result",
- "reason": "Step('compile') failed with return_code 1",
- "status_code": 1
+ "cmd": [
+ "python",
+ "-u",
+ "[BUILD]\\scripts\\slave\\compile.py",
+ "--target",
+ "Release",
+ "--src-dir",
+ "[SLAVE_BUILD]\\src",
+ "--build-tool",
+ "ninja",
+ "--compiler",
+ "clang",
+ "--"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "compile"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "RECIPE_MODULE[isolate]\\resources\\remove_build_metadata.py",
+ "--build-dir",
+ "[SLAVE_BUILD]\\src\\out\\Release",
+ "--src-dir",
+ "[SLAVE_BUILD]\\src"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "remove_build_metadata"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "RECIPE_MODULE[isolate]\\resources\\isolate.py",
+ "[SLAVE_BUILD]\\src\\tools\\swarming_client",
+ "batcharchive",
+ "--dump-json",
+ "/path/to/tmp/json",
+ "--isolate-server",
+ "https://isolateserver.appspot.com",
+ "--verbose",
+ "[SLAVE_BUILD]\\src\\out\\Release\\browser_tests.isolated.gen.json"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "isolate tests",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"browser_tests\": \"[dummy hash for browser_tests]\"@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@"
+ ]
+ },
+ {
+ "allow_subannotations": true,
+ "cmd": [
+ "python",
+ "-u",
+ "[BUILD]\\scripts\\slave\\zip_build.py",
+ "--target",
+ "Release",
+ "--build-url",
+ "gs://chromium-fyi-archive/chromium.fyi/CrWinClang(shared)",
+ "--build_revision",
+ "f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9",
+ "--factory-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"CrWinClang(shared)\", \"buildnumber\": 571, \"mastername\": \"chromium.fyi\", \"parent_buildername\": null, \"recipe\": \"chromium\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--build-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"CrWinClang(shared)\", \"buildnumber\": 571, \"mastername\": \"chromium.fyi\", \"parent_buildername\": null, \"recipe\": \"chromium\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "package build"
+ },
+ {
+ "cmd": [],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "trigger",
+ "trigger_specs": [
+ {
+ "builder_name": "CrWinClang(shared) tester"
+ }
+ ],
+ "~followup_annotations": [
+ "@@@STEP_TEXT@CrWinClang(shared) tester@@@"
+ ]
}
]

Powered by Google App Engine
This is Rietveld 408576698