Issue 137093004: Collapse matrix & clip stack in PictureRecord

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137093004: Collapse matrix & clip stack in PictureRecord (Closed)

Created:
6 years, 10 months ago by robertphillips

Modified:
6 years, 10 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This version passes the MatrixClipCollapseTest and can run through the small set of skps but doesn't handle saveLayers correctly yet. Doing so is going to take some major surgery so I would like to land a checkpoint of this.

Patch Set 1 #

Total comments: 2

Patch Set 2 : added SK_ prefix to #define #

Patch Set 3 : Fixed over application of SK_ prefix #

Patch Set 4 : Fixed over application of SK_ prefix #

Patch Set 5 : Fixed over application of SK_ prefix #

Patch Set 6 : Fixed over application of SK_ prefix #

Patch Set 7 : Fixed over application of SK_ prefix #

Patch Set 8 : Fixed over application of SK_ prefix #

Patch Set 9 : Fixed over application of SK_ prefix #

Patch Set 10 : Fixed over application of SK_ prefix #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+832 lines, -16 lines)			Patch
M	gyp/core.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	src/core/SkMatrixClipStateMgr.h	View		1 chunk	+343 lines, -0 lines	0 comments	Download
	src/core/SkMatrixClipStateMgr.cpp	View		1 chunk	+257 lines, -0 lines	0 comments	Download
M	src/core/SkPictureRecord.h	View	1	5 chunks	+13 lines, -1 line	0 comments	Download
M	src/core/SkPictureRecord.cpp	View	1	36 chunks	+209 lines, -10 lines	0 comments	Download
M	tests/MatrixClipCollapseTest.cpp	View	1 2	5 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

reed1

consider subclassing SkPictureRecord....? lgtm https://codereview.chromium.org/137093004/diff/1/src/core/SkPictureRecord.h File src/core/SkPictureRecord.h (right): https://codereview.chromium.org/137093004/diff/1/src/core/SkPictureRecord.h#newcode13 src/core/SkPictureRecord.h:13: #ifdef COLLAPSE_MATRIX_CLIP_STATE nit: SK_COLLAPS_...

6 years, 10 months ago (2014-02-10 20:59:25 UTC) #2

robertphillips

6 years, 10 months ago (2014-02-11 15:11:00 UTC) #3

Message was sent while issue was closed.

committed as r13402

https://codereview.chromium.org/137093004/diff/1/src/core/SkPictureRecord.h
File src/core/SkPictureRecord.h (right):

https://codereview.chromium.org/137093004/diff/1/src/core/SkPictureRecord.h#n...
src/core/SkPictureRecord.h:13: #ifdef COLLAPSE_MATRIX_CLIP_STATE
On 2014/02/10 20:59:25, reed1 wrote:
> nit: SK_COLLAPS_...

Done.

Expand Messages | Collapse Messages