Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1367193003: NOT FOR LANDING Allocate SVGImageForContainer on demand (Closed)

Created:
5 years, 2 months ago by davve
Modified:
5 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NOT FOR LANDING Allocate SVGImageForContainer on demand Delay creation of SVGImageForContainer until paint-time. When adding support for fragment URLs, the map from layout object to SVGImageForContainer inside ImageResource proved inadequate since one SVGImage could be used in one layout object several times with differing sizes (and fragment URLs, if we want to stick the fragment URL inside SVGImageForContainer). BUG=128055

Patch Set 1 #

Patch Set 2 : Incorperate suggested fix from fs #

Patch Set 3 : Hacked and slashed a bit more #

Patch Set 4 : Rebased #

Patch Set 5 : Removed some unintentional changes #

Patch Set 6 : Bring over tests (and a nit) from from https://codereview.chromium.org/1314793010/ #

Patch Set 7 : Rebased (one shouldn't add stuff to the end of TestExpectations) #

Patch Set 8 : Added some NeedsRebaseline and revived some LayoutListMarker code that turned out to be important #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -304 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/gradients/unprefixed-list-item-gradient.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-background.html View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-background-expected.html View 1 2 3 4 5 1 chunk +5 lines, -10 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-background-srcset.html View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-background-srcset-expected.html View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-img-src.html View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-img-src-expected.html View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-input.html View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-input-expected.html View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-svg-image.html View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-svg-image-expected.html View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-video-poster.html View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-video-poster-expected.html View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageSetValue.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageValue.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/DEPS View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.h View 1 2 5 chunks +1 line, -10 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 2 3 4 5 7 chunks +1 line, -88 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 1 2 3 chunks +1 line, -25 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.h View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.cpp View 1 2 3 chunks +17 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp View 1 2 1 chunk +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 1 2 3 4 5 6 7 6 chunks +23 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp View 1 3 chunks +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/PageSerializer.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ImagePainter.cpp View 1 2 3 3 chunks +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 2 3 4 3 chunks +16 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleImage.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StylePendingImage.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 2 3 4 5 6 7 chunks +23 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h View 1 2 2 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367193003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367193003/100001
5 years, 1 month ago (2015-10-29 07:30:16 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/87470) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-10-29 07:32:31 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367193003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367193003/120001
5 years, 1 month ago (2015-10-29 08:54:39 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/127442)
5 years, 1 month ago (2015-10-29 09:49:26 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367193003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367193003/140001
5 years, 1 month ago (2015-10-29 16:14:12 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 18:09:37 UTC) #13
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698