third_party/WebKit/Source/core/clipboard/DataTransfer.cpp - Issue 1367193003: NOT FOR LANDING Allocate SVGImageForContainer on demand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

Issue 1367193003: NOT FOR LANDING Allocate SVGImageForContainer on demand (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added some NeedsRebaseline and revived some LayoutListMarker code that turned out to be important Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/css/svg-resource-fragment-identifier-video-poster-expected.html ('k') | third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

diff --git a/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp b/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

index 5c9077f6560d8db85602e75bc62f89542e6b70a7..40184f50039e647968886a80c461b5f0fcb454b4 100644

--- a/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

+++ b/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

@@ -281,10 +281,10 @@ static void writeImageToDataObject(DataObject* dataObject, Element* element, con

{

// Shove image data into a DataObject for use as a file

ImageResource* cachedImage = getImageResource(element);

- if (!cachedImage || !cachedImage->imageForLayoutObject(element->layoutObject()) || !cachedImage->isLoaded())

+ if (!cachedImage || !cachedImage->image() || !cachedImage->isLoaded())

return;

- SharedBuffer* imageBuffer = cachedImage->imageForLayoutObject(element->layoutObject())->data();

+ SharedBuffer* imageBuffer = cachedImage->image()->data();

if (!imageBuffer || !imageBuffer->size())

return;