third_party/WebKit/Source/core/page/DragController.cpp - Issue 1367193003: NOT FOR LANDING Allocate SVGImageForContainer on demand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/DragController.cpp

Issue 1367193003: NOT FOR LANDING Allocate SVGImageForContainer on demand (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added some NeedsRebaseline and revived some LayoutListMarker code that turned out to be important Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp ('k') | third_party/WebKit/Source/core/page/PageSerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/DragController.cpp

diff --git a/third_party/WebKit/Source/core/page/DragController.cpp b/third_party/WebKit/Source/core/page/DragController.cpp

index 70493d61143cdd663012e717edd69c1d3716de71..cc5c181e5526baecfc5d87e1255dbdd7702f87ee 100644

--- a/third_party/WebKit/Source/core/page/DragController.cpp

+++ b/third_party/WebKit/Source/core/page/DragController.cpp

@@ -708,6 +708,8 @@ static Image* getImage(Element* element)

// Don't use cachedImage->imageForLayoutObject() here as that may return BitmapImages for cached SVG Images.

// Users of getImage() want access to the SVGImage, in order to figure out the filename extensions,

// which would be empty when asking the cached BitmapImages.

+ // TODO(davve): What now that imageForLayoutObject doesn't exist?

return (cachedImage && !cachedImage->errorOccurred()) ?

cachedImage->image() : nullptr;

}