third_party/WebKit/Source/core/page/PageSerializer.cpp - Issue 1367193003: NOT FOR LANDING Allocate SVGImageForContainer on demand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/PageSerializer.cpp

Issue 1367193003: NOT FOR LANDING Allocate SVGImageForContainer on demand (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added some NeedsRebaseline and revived some LayoutListMarker code that turned out to be important Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/DragController.cpp ('k') | third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/PageSerializer.cpp

diff --git a/third_party/WebKit/Source/core/page/PageSerializer.cpp b/third_party/WebKit/Source/core/page/PageSerializer.cpp

index 2c395efe5cb3fe8639465467bddf775269af8d69..1d76236cf291016cd2ca913f6b1232a0d16fa843 100644

--- a/third_party/WebKit/Source/core/page/PageSerializer.cpp

+++ b/third_party/WebKit/Source/core/page/PageSerializer.cpp

@@ -487,7 +487,7 @@ void PageSerializer::addToResources(Resource* resource, PassRefPtr<SharedBuffer>

m_resourceURLs.add(url);

}

-void PageSerializer::addImageToResources(ImageResource* image, LayoutObject* imageLayoutObject, const KURL& url)

+void PageSerializer::addImageToResources(ImageResource* image, LayoutObject*, const KURL& url) // TODO(davve): remove second parameter

{

if (!shouldAddURL(url))

return;

@@ -495,10 +495,7 @@ void PageSerializer::addImageToResources(ImageResource* image, LayoutObject* ima

if (!image || !image->hasImage() || image->errorOccurred())

return;

- RefPtr<SharedBuffer> data = imageLayoutObject ? image->imageForLayoutObject(imageLayoutObject)->data() : nullptr;

- if (!data)

- data = image->image()->data();

+ RefPtr<SharedBuffer> data = image->image()->data();

addToResources(image, data, url);

}