Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1366353002: Change test_util summarize_retried_test not to use inline python (Closed)

Created:
5 years, 2 months ago by luqui
Modified:
5 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Change test_util summarize_retried_test not to use inline python Instead we just execute logic directly in the recipe so it can be simulated. This causes a lot of expectations to now correctly report full-build failure now. BUG=536192 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -1702 lines) Patch
M scripts/slave/recipe_modules/test_utils/api.py View 2 chunks +11 lines, -37 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_32_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json View 1 chunk +7 lines, -21 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json View 1 chunk +7 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/amp_test_failure.json View 9 chunks +16 lines, -169 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/amp_test_local_fallback.json View 7 chunks +7 lines, -147 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/amp_test_local_fallback_failure.json View 9 chunks +16 lines, -169 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json View 1 chunk +9 lines, -22 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_dbg_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_dbg_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_oilpan_rel_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_ng_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_dbg_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_oilpan_rel_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_dbg_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_oilpan_rel_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel_fail.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_android_amp.json View 7 chunks +7 lines, -147 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_android_coverage.json View 4 chunks +4 lines, -84 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_android_dbg_ng.json View 10 chunks +10 lines, -210 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_android_rel_ng.json View 10 chunks +10 lines, -210 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gpu_tests.json View 1 chunk +1 line, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json View 1 chunk +9 lines, -22 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/too_many_failures_for_retcode.json View 1 chunk +9 lines, -22 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/base_unittests_failure_swarming.json View 1 chunk +9 lines, -22 lines 0 comments Download

Dependent Patchsets:

Issue 1372723002 Patch 230001
Issue 1372723002 Patch 250001

Messages

Total messages: 7 (2 generated)
luqui
ptal. This fix is required for https://codereview.chromium.org/1372723002/ because otherwise we can't verify that our fix ...
5 years, 2 months ago (2015-09-26 02:14:25 UTC) #2
Paweł Hajdan Jr.
LGTM++
5 years, 2 months ago (2015-09-28 09:45:00 UTC) #3
Sergiy Byelozyorov
lgtm
5 years, 2 months ago (2015-09-28 13:09:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366353002/1
5 years, 2 months ago (2015-09-28 17:24:22 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 17:33:35 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296910

Powered by Google App Engine
This is Rietveld 408576698