Change test_util summarize_retried_test not to use inline python

scripts/slave/recipe_modules/test_utils/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from recipe_engine import recipe_api
 from recipe_engine import util as recipe_util
 
 from .util import GTestResults, TestResults
 
 # TODO(luqui): Destroy this DEPS hack.
@@ skipping 110 matching lines @@
     finally:
       with self.m.step.defer_results():
         for t in failing_tests:
           self._summarize_retried_test(caller_api, t)
 
   def _invalid_test_results(self, test):
     self.m.tryserver.set_invalid_test_results_tryjob_result()
     self.m.python.failing_step(test.name, 'TEST RESULTS WERE INVALID')
 
   def _summarize_retried_test(self, caller_api, test):
+    """Summarizes test results and exits with a failing status if there were new
+    failures."""
     if not test.has_valid_results(caller_api, 'without patch'):
       self._invalid_test_results(test)
 
     ignored_failures = set(test.failures(caller_api, 'without patch'))
     new_failures = (
       set(test.failures(caller_api, 'with patch')) - ignored_failures)
 
     self.m.tryserver.add_failure_reason({
       'test_name': test.name,
       'new_failures': sorted(new_failures),
     })
 
+    step_text = self.format_step_text([
+        ['failures:', new_failures],
+        ['ignored:', ignored_failures]
+    ])
     try:
-      self.m.python.inline(
-        test.name,
-        r"""
-        import sys, json
-        failures = json.load(open(sys.argv[1], 'rb'))
-
-        success = True
-
-        if failures['new']:
-          success = False
-          print 'New failures:'
-          for f in failures['new']:
-            print f
-
-        if failures['ignored']:
-          print 'Ignored failures:'
-          for f in failures['ignored']:
-            print f
-
-        sys.exit(0 if success else 1)
-        """,
-        args=[
-          self.m.json.input({
-            'new': list(new_failures),
-            'ignored': list(ignored_failures),
-          })
-        ],
-      )
+      if new_failures:
+        self.m.python.failing_step(test.name, step_text)
+      else:
+        self.m.python.succeeding_step(test.name, step_text)
     finally:
-      p = self.m.step.active_result.presentation
-
-      p.step_text += self.format_step_text([
-          ['failures:', new_failures],
-          ['ignored:', ignored_failures]
-      ])
-
       if new_failures:
-        p.status = self.m.step.FAILURE
         self.m.tryserver.set_test_failure_tryjob_result()
       elif ignored_failures:
-        p.status = self.m.step.WARNING
+        self.m.step.active_result.presentation.status = self.m.step.WARNING
 
   @recipe_util.returns_placeholder
   def test_results(self, add_json_log=True):
     """A placeholder which will expand to '/tmp/file'.
 
     The recipe must provide the expected --json-test-results flag.
 
     The test_results will be an instance of the TestResults class.
     """
     return TestResultsOutputPlaceholder(self, add_json_log)
 
   @recipe_util.returns_placeholder
   def gtest_results(self, add_json_log=True):
     """A placeholder which will expand to
     '--test-launcher-summary-output=/tmp/file'.
 
     Provides the --test-launcher-summary-output flag since --flag=value
     (i.e. a single token in the command line) is the required format.
 
     The test_results will be an instance of the GTestResults class.
     """
     return GTestResultsOutputPlaceholder(self, add_json_log)