Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json

Issue 1366353002: Change test_util summarize_retried_test not to use inline python (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
diff --git a/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json b/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
index eafdc4c593bc491b026bd25a1a7bb5832af5c0ff..771672fd142b6d8a81cd960a7f08cd89d292d6d5 100644
--- a/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
+++ b/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
@@ -315,33 +315,19 @@
"cmd": [
"python",
"-u",
- "\nimport sys, json\nfailures = json.load(open(sys.argv[1], 'rb'))\n\nsuccess = True\n\nif failures['new']:\n success = False\n print 'New failures:'\n for f in failures['new']:\n print f\n\nif failures['ignored']:\n print 'Ignored failures:'\n for f in failures['ignored']:\n print f\n\nsys.exit(0 if success else 1)\n",
- "{\"ignored\": [], \"new\": [\"bad/totally-bad-probably.html\", \"tricky/totally-maybe-not-awesome.html\"]}"
+ "import sys; sys.exit(1)"
],
"cwd": "[SLAVE_BUILD]",
"name": "webkit_tests",
"~followup_annotations": [
+ "step returned non-zero exit code: 1",
"@@@STEP_TEXT@<br/>failures:<br/>bad/totally-bad-probably.html<br/>tricky/totally-maybe-not-awesome.html<br/>@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@import sys, json@@@",
- "@@@STEP_LOG_LINE@python.inline@failures = json.load(open(sys.argv[1], 'rb'))@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@success = True@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ success = False@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'New failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'Ignored failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@sys.exit(0 if success else 1)@@@",
- "@@@STEP_LOG_END@python.inline@@@",
"@@@STEP_FAILURE@@@"
]
+ },
+ {
+ "name": "$final_result",
+ "reason": "1 out of 1 aggregated steps failed. Failures: Step('webkit_tests') failed with return_code 1",
+ "status_code": 1
}
]

Powered by Google App Engine
This is Rietveld 408576698