Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2124)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/amp_test_failure.json

Issue 1366353002: Change test_util summarize_retried_test not to use inline python (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json ('k') | scripts/slave/recipes/chromium_trybot.expected/amp_test_local_fallback.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/chromium_trybot.expected/amp_test_failure.json
diff --git a/scripts/slave/recipes/chromium_trybot.expected/amp_test_failure.json b/scripts/slave/recipes/chromium_trybot.expected/amp_test_failure.json
index 61a89bb6cc895aaf2fdd06c2ab19551dbc5a3455..40e0e1fdcdf76e85b85c1c03308823b48d6307d5 100644
--- a/scripts/slave/recipes/chromium_trybot.expected/amp_test_failure.json
+++ b/scripts/slave/recipes/chromium_trybot.expected/amp_test_failure.json
@@ -2562,32 +2562,12 @@
"cmd": [
"python",
"-u",
- "\nimport sys, json\nfailures = json.load(open(sys.argv[1], 'rb'))\n\nsuccess = True\n\nif failures['new']:\n success = False\n print 'New failures:'\n for f in failures['new']:\n print f\n\nif failures['ignored']:\n print 'Ignored failures:'\n for f in failures['ignored']:\n print f\n\nsys.exit(0 if success else 1)\n",
- "{\"ignored\": [\"TestB\"], \"new\": []}"
+ "import sys; sys.exit(0)"
],
"cwd": "[SLAVE_BUILD]",
"name": "AndroidWebViewTest",
"~followup_annotations": [
"@@@STEP_TEXT@<br/>ignored:<br/>TestB<br/>@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@import sys, json@@@",
- "@@@STEP_LOG_LINE@python.inline@failures = json.load(open(sys.argv[1], 'rb'))@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@success = True@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ success = False@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'New failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'Ignored failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@sys.exit(0 if success else 1)@@@",
- "@@@STEP_LOG_END@python.inline@@@",
"@@@STEP_WARNINGS@@@"
]
},
@@ -2595,32 +2575,12 @@
"cmd": [
"python",
"-u",
- "\nimport sys, json\nfailures = json.load(open(sys.argv[1], 'rb'))\n\nsuccess = True\n\nif failures['new']:\n success = False\n print 'New failures:'\n for f in failures['new']:\n print f\n\nif failures['ignored']:\n print 'Ignored failures:'\n for f in failures['ignored']:\n print f\n\nsys.exit(0 if success else 1)\n",
- "{\"ignored\": [\"TestB\"], \"new\": []}"
+ "import sys; sys.exit(0)"
],
"cwd": "[SLAVE_BUILD]",
"name": "ContentShellTest",
"~followup_annotations": [
"@@@STEP_TEXT@<br/>ignored:<br/>TestB<br/>@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@import sys, json@@@",
- "@@@STEP_LOG_LINE@python.inline@failures = json.load(open(sys.argv[1], 'rb'))@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@success = True@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ success = False@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'New failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'Ignored failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@sys.exit(0 if success else 1)@@@",
- "@@@STEP_LOG_END@python.inline@@@",
"@@@STEP_WARNINGS@@@"
]
},
@@ -2628,32 +2588,12 @@
"cmd": [
"python",
"-u",
- "\nimport sys, json\nfailures = json.load(open(sys.argv[1], 'rb'))\n\nsuccess = True\n\nif failures['new']:\n success = False\n print 'New failures:'\n for f in failures['new']:\n print f\n\nif failures['ignored']:\n print 'Ignored failures:'\n for f in failures['ignored']:\n print f\n\nsys.exit(0 if success else 1)\n",
- "{\"ignored\": [\"TestB\"], \"new\": []}"
+ "import sys; sys.exit(0)"
],
"cwd": "[SLAVE_BUILD]",
"name": "ChromePublicTest",
"~followup_annotations": [
"@@@STEP_TEXT@<br/>ignored:<br/>TestB<br/>@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@import sys, json@@@",
- "@@@STEP_LOG_LINE@python.inline@failures = json.load(open(sys.argv[1], 'rb'))@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@success = True@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ success = False@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'New failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'Ignored failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@sys.exit(0 if success else 1)@@@",
- "@@@STEP_LOG_END@python.inline@@@",
"@@@STEP_WARNINGS@@@"
]
},
@@ -2661,32 +2601,12 @@
"cmd": [
"python",
"-u",
- "\nimport sys, json\nfailures = json.load(open(sys.argv[1], 'rb'))\n\nsuccess = True\n\nif failures['new']:\n success = False\n print 'New failures:'\n for f in failures['new']:\n print f\n\nif failures['ignored']:\n print 'Ignored failures:'\n for f in failures['ignored']:\n print f\n\nsys.exit(0 if success else 1)\n",
- "{\"ignored\": [\"TestB\"], \"new\": []}"
+ "import sys; sys.exit(0)"
],
"cwd": "[SLAVE_BUILD]",
"name": "ChromeSyncShellTest",
"~followup_annotations": [
"@@@STEP_TEXT@<br/>ignored:<br/>TestB<br/>@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@import sys, json@@@",
- "@@@STEP_LOG_LINE@python.inline@failures = json.load(open(sys.argv[1], 'rb'))@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@success = True@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ success = False@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'New failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'Ignored failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@sys.exit(0 if success else 1)@@@",
- "@@@STEP_LOG_END@python.inline@@@",
"@@@STEP_WARNINGS@@@"
]
},
@@ -2694,32 +2614,13 @@
"cmd": [
"python",
"-u",
- "\nimport sys, json\nfailures = json.load(open(sys.argv[1], 'rb'))\n\nsuccess = True\n\nif failures['new']:\n success = False\n print 'New failures:'\n for f in failures['new']:\n print f\n\nif failures['ignored']:\n print 'Ignored failures:'\n for f in failures['ignored']:\n print f\n\nsys.exit(0 if success else 1)\n",
- "{\"ignored\": [], \"new\": [\"Test.Two\"]}"
+ "import sys; sys.exit(1)"
],
"cwd": "[SLAVE_BUILD]",
"name": "base_unittests",
"~followup_annotations": [
+ "step returned non-zero exit code: 1",
"@@@STEP_TEXT@<br/>failures:<br/>Test.Two<br/>@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@import sys, json@@@",
- "@@@STEP_LOG_LINE@python.inline@failures = json.load(open(sys.argv[1], 'rb'))@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@success = True@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ success = False@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'New failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'Ignored failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@sys.exit(0 if success else 1)@@@",
- "@@@STEP_LOG_END@python.inline@@@",
"@@@STEP_FAILURE@@@",
"@@@SET_BUILD_PROPERTY@failure_type@\"TEST_FAILURE\"@@@"
]
@@ -2728,32 +2629,12 @@
"cmd": [
"python",
"-u",
- "\nimport sys, json\nfailures = json.load(open(sys.argv[1], 'rb'))\n\nsuccess = True\n\nif failures['new']:\n success = False\n print 'New failures:'\n for f in failures['new']:\n print f\n\nif failures['ignored']:\n print 'Ignored failures:'\n for f in failures['ignored']:\n print f\n\nsys.exit(0 if success else 1)\n",
- "{\"ignored\": [\"TestB\"], \"new\": []}"
+ "import sys; sys.exit(0)"
],
"cwd": "[SLAVE_BUILD]",
"name": "junit_unit_tests",
"~followup_annotations": [
"@@@STEP_TEXT@<br/>ignored:<br/>TestB<br/>@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@import sys, json@@@",
- "@@@STEP_LOG_LINE@python.inline@failures = json.load(open(sys.argv[1], 'rb'))@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@success = True@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ success = False@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'New failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'Ignored failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@sys.exit(0 if success else 1)@@@",
- "@@@STEP_LOG_END@python.inline@@@",
"@@@STEP_WARNINGS@@@"
]
},
@@ -2761,32 +2642,12 @@
"cmd": [
"python",
"-u",
- "\nimport sys, json\nfailures = json.load(open(sys.argv[1], 'rb'))\n\nsuccess = True\n\nif failures['new']:\n success = False\n print 'New failures:'\n for f in failures['new']:\n print f\n\nif failures['ignored']:\n print 'Ignored failures:'\n for f in failures['ignored']:\n print f\n\nsys.exit(0 if success else 1)\n",
- "{\"ignored\": [\"TestB\"], \"new\": []}"
+ "import sys; sys.exit(0)"
],
"cwd": "[SLAVE_BUILD]",
"name": "chrome_junit_tests",
"~followup_annotations": [
"@@@STEP_TEXT@<br/>ignored:<br/>TestB<br/>@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@import sys, json@@@",
- "@@@STEP_LOG_LINE@python.inline@failures = json.load(open(sys.argv[1], 'rb'))@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@success = True@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ success = False@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'New failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'Ignored failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@sys.exit(0 if success else 1)@@@",
- "@@@STEP_LOG_END@python.inline@@@",
"@@@STEP_WARNINGS@@@"
]
},
@@ -2794,32 +2655,12 @@
"cmd": [
"python",
"-u",
- "\nimport sys, json\nfailures = json.load(open(sys.argv[1], 'rb'))\n\nsuccess = True\n\nif failures['new']:\n success = False\n print 'New failures:'\n for f in failures['new']:\n print f\n\nif failures['ignored']:\n print 'Ignored failures:'\n for f in failures['ignored']:\n print f\n\nsys.exit(0 if success else 1)\n",
- "{\"ignored\": [\"TestB\"], \"new\": []}"
+ "import sys; sys.exit(0)"
],
"cwd": "[SLAVE_BUILD]",
"name": "content_junit_tests",
"~followup_annotations": [
"@@@STEP_TEXT@<br/>ignored:<br/>TestB<br/>@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@import sys, json@@@",
- "@@@STEP_LOG_LINE@python.inline@failures = json.load(open(sys.argv[1], 'rb'))@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@success = True@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ success = False@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'New failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['new']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@if failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print 'Ignored failures:'@@@",
- "@@@STEP_LOG_LINE@python.inline@ for f in failures['ignored']:@@@",
- "@@@STEP_LOG_LINE@python.inline@ print f@@@",
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@sys.exit(0 if success else 1)@@@",
- "@@@STEP_LOG_END@python.inline@@@",
"@@@STEP_WARNINGS@@@"
]
},
@@ -2893,7 +2734,13 @@
"@@@STEP_LOG_LINE@python.inline@ for l in f.readlines():@@@",
"@@@STEP_LOG_LINE@python.inline@ print l@@@",
"@@@STEP_LOG_LINE@python.inline@ os.remove(report)@@@",
- "@@@STEP_LOG_END@python.inline@@@"
+ "@@@STEP_LOG_END@python.inline@@@",
+ "@@@SET_BUILD_PROPERTY@failure_hash@\"01e67cd697806ea33f239ac8c503b9ca0c020466\"@@@"
]
+ },
+ {
+ "name": "$final_result",
+ "reason": "1 out of 8 aggregated steps failed. Failures: Step('base_unittests') failed with return_code 1",
+ "status_code": 1
}
]
« no previous file with comments | « scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json ('k') | scripts/slave/recipes/chromium_trybot.expected/amp_test_local_fallback.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698