Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1365503005: [es6] Fix invalid ToString in implementation of ToName. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix invalid ToString in implementation of ToName. R=jarin@chromium.org Committed: https://crrev.com/09626525fea63396c8a200deb9081d6dd1034d57 Cr-Commit-Position: refs/heads/master@{#30957}

Patch Set 1 #

Patch Set 2 : No inline for isolate access. #

Patch Set 3 : Meh! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Benedikt Meurer
5 years, 2 months ago (2015-09-25 11:39:30 UTC) #1
Benedikt Meurer
Michi: PTAL Georg: FYI
5 years, 2 months ago (2015-09-25 11:39:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365503005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365503005/1
5 years, 2 months ago (2015-09-25 11:40:08 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/4679) v8_linux64_rel on ...
5 years, 2 months ago (2015-09-25 11:42:10 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365503005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365503005/20001
5 years, 2 months ago (2015-09-25 11:44:19 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/8325) v8_mac_rel on ...
5 years, 2 months ago (2015-09-25 11:46:00 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365503005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365503005/40001
5 years, 2 months ago (2015-09-25 16:07:33 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-25 16:13:57 UTC) #14
Jarin
lgtm
5 years, 2 months ago (2015-09-28 05:10:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365503005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365503005/40001
5 years, 2 months ago (2015-09-28 05:10:47 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-28 05:34:00 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 05:34:22 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/09626525fea63396c8a200deb9081d6dd1034d57
Cr-Commit-Position: refs/heads/master@{#30957}

Powered by Google App Engine
This is Rietveld 408576698