Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1365503005: [es6] Fix invalid ToString in implementation of ToName. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Meh! Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 3801 matching lines...) Expand 10 before | Expand all | Expand 10 after
3812 3812
3813 // Load the argument into v0 and convert it. 3813 // Load the argument into v0 and convert it.
3814 VisitForAccumulatorValue(args->at(0)); 3814 VisitForAccumulatorValue(args->at(0));
3815 3815
3816 Label convert, done_convert; 3816 Label convert, done_convert;
3817 __ JumpIfSmi(v0, &convert); 3817 __ JumpIfSmi(v0, &convert);
3818 STATIC_ASSERT(FIRST_NAME_TYPE == FIRST_TYPE); 3818 STATIC_ASSERT(FIRST_NAME_TYPE == FIRST_TYPE);
3819 __ GetObjectType(v0, a1, a1); 3819 __ GetObjectType(v0, a1, a1);
3820 __ Branch(&done_convert, le, a1, Operand(LAST_NAME_TYPE)); 3820 __ Branch(&done_convert, le, a1, Operand(LAST_NAME_TYPE));
3821 __ bind(&convert); 3821 __ bind(&convert);
3822 ToStringStub stub(isolate()); 3822 __ Push(v0);
3823 __ mov(a0, v0); 3823 __ CallRuntime(Runtime::kToName, 1);
3824 __ CallStub(&stub);
3825 __ bind(&done_convert); 3824 __ bind(&done_convert);
3826 context()->Plug(v0); 3825 context()->Plug(v0);
3827 } 3826 }
3828 3827
3829 3828
3830 void FullCodeGenerator::EmitToObject(CallRuntime* expr) { 3829 void FullCodeGenerator::EmitToObject(CallRuntime* expr) {
3831 ZoneList<Expression*>* args = expr->arguments(); 3830 ZoneList<Expression*>* args = expr->arguments();
3832 DCHECK_EQ(1, args->length()); 3831 DCHECK_EQ(1, args->length());
3833 3832
3834 // Load the argument into a0 and convert it. 3833 // Load the argument into a0 and convert it.
(...skipping 1389 matching lines...) Expand 10 before | Expand all | Expand 10 after
5224 reinterpret_cast<uint32_t>( 5223 reinterpret_cast<uint32_t>(
5225 isolate->builtins()->OsrAfterStackCheck()->entry())); 5224 isolate->builtins()->OsrAfterStackCheck()->entry()));
5226 return OSR_AFTER_STACK_CHECK; 5225 return OSR_AFTER_STACK_CHECK;
5227 } 5226 }
5228 5227
5229 5228
5230 } // namespace internal 5229 } // namespace internal
5231 } // namespace v8 5230 } // namespace v8
5232 5231
5233 #endif // V8_TARGET_ARCH_MIPS 5232 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698