src/full-codegen/mips/full-codegen-mips.cc - Issue 1365503005: [es6] Fix invalid ToString in implementation of ToName.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1365503005: [es6] Fix invalid ToString in implementation of ToName. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Meh! Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/mips/full-codegen-mips.cc

diff --git a/src/full-codegen/mips/full-codegen-mips.cc b/src/full-codegen/mips/full-codegen-mips.cc

index e9019b9cb70ac854b56cf2afc8ee0ca11c61c287..747d686e6b7c052385418d3ed641f17551c9ced9 100644

--- a/src/full-codegen/mips/full-codegen-mips.cc

+++ b/src/full-codegen/mips/full-codegen-mips.cc

@@ -3819,9 +3819,8 @@ void FullCodeGenerator::EmitToName(CallRuntime* expr) {

__ GetObjectType(v0, a1, a1);

__ Branch(&done_convert, le, a1, Operand(LAST_NAME_TYPE));

__ bind(&convert);

- ToStringStub stub(isolate());

- __ mov(a0, v0);

- __ CallStub(&stub);

+ __ Push(v0);

+ __ CallRuntime(Runtime::kToName, 1);

__ bind(&done_convert);

context()->Plug(v0);

}