Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 1365503005: [es6] Fix invalid ToString in implementation of ToName. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Meh! Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 3804 matching lines...) Expand 10 before | Expand all | Expand 10 after
3815 3815
3816 // Load the argument into v0 and convert it. 3816 // Load the argument into v0 and convert it.
3817 VisitForAccumulatorValue(args->at(0)); 3817 VisitForAccumulatorValue(args->at(0));
3818 3818
3819 Label convert, done_convert; 3819 Label convert, done_convert;
3820 __ JumpIfSmi(v0, &convert); 3820 __ JumpIfSmi(v0, &convert);
3821 STATIC_ASSERT(FIRST_NAME_TYPE == FIRST_TYPE); 3821 STATIC_ASSERT(FIRST_NAME_TYPE == FIRST_TYPE);
3822 __ GetObjectType(v0, a1, a1); 3822 __ GetObjectType(v0, a1, a1);
3823 __ Branch(&done_convert, le, a1, Operand(LAST_NAME_TYPE)); 3823 __ Branch(&done_convert, le, a1, Operand(LAST_NAME_TYPE));
3824 __ bind(&convert); 3824 __ bind(&convert);
3825 ToStringStub stub(isolate()); 3825 __ Push(v0);
3826 __ mov(a0, v0); 3826 __ CallRuntime(Runtime::kToName, 1);
3827 __ CallStub(&stub);
3828 __ bind(&done_convert); 3827 __ bind(&done_convert);
3829 context()->Plug(v0); 3828 context()->Plug(v0);
3830 } 3829 }
3831 3830
3832 3831
3833 void FullCodeGenerator::EmitToObject(CallRuntime* expr) { 3832 void FullCodeGenerator::EmitToObject(CallRuntime* expr) {
3834 ZoneList<Expression*>* args = expr->arguments(); 3833 ZoneList<Expression*>* args = expr->arguments();
3835 DCHECK_EQ(1, args->length()); 3834 DCHECK_EQ(1, args->length());
3836 3835
3837 // Load the argument into a0 and convert it. 3836 // Load the argument into a0 and convert it.
(...skipping 1392 matching lines...) Expand 10 before | Expand all | Expand 10 after
5230 reinterpret_cast<uint64_t>( 5229 reinterpret_cast<uint64_t>(
5231 isolate->builtins()->OsrAfterStackCheck()->entry())); 5230 isolate->builtins()->OsrAfterStackCheck()->entry()));
5232 return OSR_AFTER_STACK_CHECK; 5231 return OSR_AFTER_STACK_CHECK;
5233 } 5232 }
5234 5233
5235 5234
5236 } // namespace internal 5235 } // namespace internal
5237 } // namespace v8 5236 } // namespace v8
5238 5237
5239 #endif // V8_TARGET_ARCH_MIPS64 5238 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698