IndexedDB: Replace use of DOMError with DOMException

IndexedDB: Replace use of DOMError with DOMException

DOMError has been removed from the DOM standard in favor of
DOMException, and the Indexed DB draft spec has been updated
to use DOMException for error attributes.

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/XAlBg66UB7c/G4GNCFLnwCQJ
Editor's Draft: https://w3c.github.io/IndexedDB/
R=philipj@opera.com
BUG=460725
Committed: https://crrev.com/195d14404404b34445066648de61f901a1b70d3f
Cr-Commit-Position: refs/heads/master@{#358389}

[jsbell, 2015-09-23 17:35:39]

migrated from https://codereview.chromium.org/1182233003/

[jsbell, 2015-11-06 00:17:43]

philipj@ - how's this?

(Deprecating DOMError's ctor can be a different CL)

[jsbell, 2015-11-06 00:19:50]

Description was changed from

==========
IndexedDB: Replace use of DOMError with DOMException

DOMError has been removed from the DOM standard in favor of
DOMException. We've added instrumentation to measure the use of the
constructors and methods (http://crrev.com/1151023004), but given that
DOMException is drop-in compatible (same name/message properties) when
minted by an API, we can try just switching over. This would only
break code that does 'instanceof' tests, and we didn't even have any
of those for IndexedDB.

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/XAlBg66UB7c/G4GNCFLn...
R=philipj@opera.com
BUG=460725
==========

to

==========
IndexedDB: Replace use of DOMError with DOMException

DOMError has been removed from the DOM standard in favor of
DOMException, and the Indexed DB draft spec has been updated
to use DOMException for error attributes.

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/XAlBg66UB7c/G4GNCFLn...
Editor's Draft: https://w3c.github.io/IndexedDB/
R=philipj@opera.com
BUG=460725
==========

[philipj_slow, 2015-11-06 08:42:37]

lgtm % nits

https://codereview.chromium.org/1364823002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp (right):

https://codereview.chromium.org/1364823002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp:34: #include
"core/dom/ExceptionCode.h"
Is this new include really needed? Seems like it should be possible to just
forward-declare DOMException since it's just passed around.

https://codereview.chromium.org/1364823002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/indexeddb/IDBTransaction.idl (right):

https://codereview.chromium.org/1364823002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/indexeddb/IDBTransaction.idl:47: [Measure]
readonly attribute DOMException error;
Maybe drop [Measure] here and any other places where it's served its purpose.

[jsbell, 2015-11-06 18:41:56]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2015-11-06 18:41:56]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com
Link to the patchset: https://codereview.chromium.org/1364823002/#ps20001
(title: "Drop [Measure] where done")

[commit-bot: I haz the power, 2015-11-06 18:42:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364823002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364823002/20001

[jsbell, 2015-11-06 18:42:34]

https://codereview.chromium.org/1364823002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp (right):

https://codereview.chromium.org/1364823002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp:34: #include
"core/dom/ExceptionCode.h"
On 2015/11/06 08:42:37, philipj wrote:
> Is this new include really needed? Seems like it should be possible to just
> forward-declare DOMException since it's just passed around.

This is for the use of the ExceptionCode enum e.g.
exceptionState.throwDOMException(InvalidStateError, ...)

Previously it was referenced indirectly - it should have been there all along.

https://codereview.chromium.org/1364823002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/indexeddb/IDBTransaction.idl (right):

https://codereview.chromium.org/1364823002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/indexeddb/IDBTransaction.idl:47: [Measure]
readonly attribute DOMException error;
On 2015/11/06 08:42:37, philipj wrote:
> Maybe drop [Measure] here and any other places where it's served its purpose.

Done.

[commit-bot: I haz the power, 2015-11-06 21:06:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-06 21:07:31]

Patchset 2 (id:??) landed as
https://crrev.com/195d14404404b34445066648de61f901a1b70d3f
Cr-Commit-Position: refs/heads/master@{#358389}