IndexedDB: Replace use of DOMError with DOMException

third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 13 matching lines @@
  */
 
 #include "config.h"
 #include "modules/indexeddb/IDBDatabase.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "bindings/core/v8/Nullable.h"
 #include "bindings/core/v8/SerializedScriptValue.h"
 #include "bindings/modules/v8/V8BindingForModules.h"
+#include "core/dom/ExceptionCode.h"

[philipj_slow, 2015/11/06 08:42:37]

Is this new include really needed? Seems like it should be possible to just
forward-declare DOMException since it's just passed around.

[jsbell, 2015/11/06 18:42:34]

This is for the use of the ExceptionCode enum e.g.
exceptionState.throwDOMException(InvalidStateError, ...)

Previously it was referenced indirectly - it should have been there all along.

 #include "core/dom/ExecutionContext.h"
 #include "core/events/EventQueue.h"
 #include "core/inspector/ScriptCallStack.h"
 #include "modules/indexeddb/IDBAny.h"
 #include "modules/indexeddb/IDBEventDispatcher.h"
 #include "modules/indexeddb/IDBHistograms.h"
 #include "modules/indexeddb/IDBIndex.h"
 #include "modules/indexeddb/IDBKeyPath.h"
 #include "modules/indexeddb/IDBTracing.h"
 #include "modules/indexeddb/IDBVersionChangeEvent.h"
@@ skipping 98 matching lines @@
 
     if (transaction->isVersionChange()) {
         ASSERT(m_versionChangeTransaction == transaction);
         m_versionChangeTransaction = nullptr;
     }
 
     if (m_closePending && m_transactions.isEmpty())
         closeConnection();
 }
 
-void IDBDatabase::onAbort(int64_t transactionId, DOMError* error)
+void IDBDatabase::onAbort(int64_t transactionId, DOMException* error)
 {
     ASSERT(m_transactions.contains(transactionId));
     m_transactions.get(transactionId)->onAbort(error);
 }
 
 void IDBDatabase::onComplete(int64_t transactionId)
 {
     ASSERT(m_transactions.contains(transactionId));
     m_transactions.get(transactionId)->onComplete();
 }
@@ skipping 285 matching lines @@
 {
     return EventTargetNames::IDBDatabase;
 }
 
 ExecutionContext* IDBDatabase::executionContext() const
 {
     return ActiveDOMObject::executionContext();
 }
 
 } // namespace blink