third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp - Issue 1364823002: IndexedDB: Replace use of DOMError with DOMException

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp

Issue 1364823002: IndexedDB: Replace use of DOMError with DOMException (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Drop [Measure] where done Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp

index 385a831eb022903621b1cfe163992786934f9b02..5801007aa06dd4c89e75c569b9c0d65193a52428 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp

@@ -31,6 +31,7 @@

#include "bindings/core/v8/ExceptionState.h"

#include "bindings/modules/v8/V8BindingForModules.h"

+#include "core/dom/DOMException.h"

#include "core/dom/Document.h"

#include "core/dom/ExceptionCode.h"

#include "modules/indexeddb/IDBDatabase.h"

@@ -83,7 +84,7 @@ IDBRequest* IDBFactory::getDatabaseNames(ScriptState* scriptState, ExceptionStat

IDBRequest* request = IDBRequest::create(scriptState, IDBAny::createNull(), nullptr);

if (!m_permissionClient->allowIndexedDB(scriptState->executionContext(), "Database Listing")) {

- request->onError(DOMError::create(UnknownError, permissionDeniedErrorMessage));

+ request->onError(DOMException::create(UnknownError, permissionDeniedErrorMessage));

return request;

}

@@ -117,7 +118,7 @@ IDBOpenDBRequest* IDBFactory::openInternal(ScriptState* scriptState, const Strin

IDBOpenDBRequest* request = IDBOpenDBRequest::create(scriptState, databaseCallbacks, transactionId, version);

if (!m_permissionClient->allowIndexedDB(scriptState->executionContext(), name)) {

- request->onError(DOMError::create(UnknownError, permissionDeniedErrorMessage));

+ request->onError(DOMException::create(UnknownError, permissionDeniedErrorMessage));

return request;

}

@@ -145,7 +146,7 @@ IDBOpenDBRequest* IDBFactory::deleteDatabase(ScriptState* scriptState, const Str

IDBOpenDBRequest* request = IDBOpenDBRequest::create(scriptState, nullptr, 0, IDBDatabaseMetadata::DefaultIntVersion);

if (!m_permissionClient->allowIndexedDB(scriptState->executionContext(), name)) {

- request->onError(DOMError::create(UnknownError, permissionDeniedErrorMessage));

+ request->onError(DOMException::create(UnknownError, permissionDeniedErrorMessage));

return request;

}