Rename FROM_HERE to BLINK_FROM_HERE.

Rename FROM_HERE to BLINK_FROM_HERE.

This collides with a Chromium macro of the same name, which makes including
Chromium headers from Blink problematic. Now that the repositories have merged,
we should avoid macro redefinition.

BUG=536059
Committed: https://crrev.com/decfc3e5af4e79753f407e03b5ae7a5b72ded659
Cr-Commit-Position: refs/heads/master@{#354672}

[jbroman, 2015-09-25 17:16:44]

jbroman@chromium.org changed reviewers:
+ mkwst@chromium.org, skyostil@chromium.org

[jbroman, 2015-09-25 17:18:18]

WDYT? I couldn't come up with a good name, but unfortunately macros aren't
namespaced, and this collision will become an issue (in particular, I've run
into it while trying to include a cc header from Blink, which is being discussed
on blink-dev).

[Sami, 2015-09-25 18:11:14]

I see there's ongoing discussion about whether we could just depend on base/ in
Blink. If that's possible, then we could just use the real FROM_HERE macro in
Blink and drop the WebTraceLocation compatibility shim (which is designed to be
a drop in replacement of the base equivalent).

I think that's ultimately the model we want, so the question is do we need an
intermediate hack like this or not? I'd prefer to avoid it if we can, but if
this unblocks more critical refactoring then I'd be fine with it.

[jbroman, 2015-09-25 18:53:12]

On 2015/09/25 at 18:11:14, skyostil wrote:
> I see there's ongoing discussion about whether we could just depend on base/
in Blink. If that's possible, then we could just use the real FROM_HERE macro in
Blink and drop the WebTraceLocation compatibility shim (which is designed to be
a drop in replacement of the base equivalent).
> 
> I think that's ultimately the model we want, so the question is do we need an
intermediate hack like this or not? I'd prefer to avoid it if we can, but if
this unblocks more critical refactoring then I'd be fine with it.

It's not currently urgent. I haven't yet seen anyone propose allowing
base/location.h (or all of base/) throughout Blink, though I agree it might be
where we ultimately end up.

[Mike West, 2015-09-29 07:13:27]

mkwst@chromium.org changed reviewers:
+ esprehn@chromium.org

[Mike West, 2015-09-29 07:13:28]

If you decide to go this route, the change LGTM (to avoid excitingly
cross-oceanic waiting periods).

I'd suggest poking at blink-dev@ (and esprehen@ in particular) to discuss just
using location.h directly. That seems like a better option, but this is a
totally reasonable middle ground.

[esprehn, 2015-09-29 08:01:33]

This should be WTF_FROM_HERE and we should probably make WTF depend on
base. Something like these tracing functions should be part of WTF not
platform.

I'd like to hold off on this for now though, merging repositories doesn't
actually change anything yet. There's no need to rush. :)
On Sep 29, 2015 12:13 AM, <mkwst@chromium.org> wrote:

> If you decide to go this route, the change LGTM (to avoid excitingly
> cross-oceanic waiting periods).
>
> I'd suggest poking at blink-dev@ (and esprehen@ in particular) to discuss
> just
> using location.h directly. That seems like a better option, but this is a
> totally reasonable middle ground.
>
> https://codereview.chromium.org/1362973004/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[danakj, 2015-10-15 19:03:19]

On 2015/09/29 08:01:33, esprehn wrote:
> This should be WTF_FROM_HERE and we should probably make WTF depend on
> base. Something like these tracing functions should be part of WTF not
> platform.
> 
> I'd like to hold off on this for now though, merging repositories doesn't
> actually change anything yet. There's no need to rush. :)

Can we just rename this macro as a small and simple step?

[esprehn, 2015-10-15 19:17:10]

On 2015/10/15 at 19:03:19, danakj wrote:
> On 2015/09/29 08:01:33, esprehn wrote:
> > This should be WTF_FROM_HERE and we should probably make WTF depend on
> > base. Something like these tracing functions should be part of WTF not
> > platform.
> > 
> > I'd like to hold off on this for now though, merging repositories doesn't
> > actually change anything yet. There's no need to rush. :)
> 
> Can we just rename this macro as a small and simple step?

Is there an advantage to doing this yet if we're not using base anywhere yet?

[danakj, 2015-10-15 19:58:44]

On Thu, Oct 15, 2015 at 12:17 PM, <esprehn@chromium.org> wrote:

> On 2015/10/15 at 19:03:19, danakj wrote:
>
>> On 2015/09/29 08:01:33, esprehn wrote:
>> > This should be WTF_FROM_HERE and we should probably make WTF depend on
>> > base. Something like these tracing functions should be part of WTF not
>> > platform.
>> >
>> > I'd like to hold off on this for now though, merging repositories
>> doesn't
>> > actually change anything yet. There's no need to rush. :)
>>
>
> Can we just rename this macro as a small and simple step?
>>
>
> Is there an advantage to doing this yet if we're not using base anywhere
> yet?
>

Base headers are transitively included from other chromium headers, for
places that would like to use chromium things like platform/graphics. We
had similar problems with LOG which was renamed to WTF_LOG in the past.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[esprehn, 2015-10-15 20:01:26]

On 2015/10/15 at 19:58:44, danakj wrote:
> On Thu, Oct 15, 2015 at 12:17 PM, <esprehn@chromium.org> wrote:
> 
> > On 2015/10/15 at 19:03:19, danakj wrote:
> >
> > Can we just rename this macro as a small and simple step?
> >>
> >
> > Is there an advantage to doing this yet if we're not using base anywhere
> > yet?
> >
> 
> Base headers are transitively included from other chromium headers, for
> places that would like to use chromium things like platform/graphics. We
> had similar problems with LOG which was renamed to WTF_LOG in the past.
> 

Seems reasonable. lgtm

[jbroman, 2015-10-17 03:08:45]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2015-10-17 03:08:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1362973004/#ps20001
(title: "update")

[commit-bot: I haz the power, 2015-10-17 03:09:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362973004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362973004/20001

[commit-bot: I haz the power, 2015-10-17 04:37:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-17 04:38:32]

Patchset 2 (id:??) landed as
https://crrev.com/decfc3e5af4e79753f407e03b5ae7a5b72ded659
Cr-Commit-Position: refs/heads/master@{#354672}