Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 1359243002: [GN]: Fix bug where cflag vars were not being written on non-PCH builds (Closed)

Created:
5 years, 3 months ago by Bons
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, tfarina, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN]: Fix bug where cflag vars were not being written on non-PCH builds On non-PCH builds, the cflags* vars were not being properly written in the binary output. Also removed some dead vars. BUG=535040 Committed: https://crrev.com/4f28b8c3f0895976d060159edd5271c8a6a2a92a Cr-Commit-Position: refs/heads/master@{#350294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M tools/gn/ninja_binary_target_writer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn/ninja_binary_target_writer_unittest.cc View 4 chunks +4 lines, -2 lines 0 comments Download
M tools/gn/variables.h View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bons
5 years, 3 months ago (2015-09-23 01:57:24 UTC) #2
brettw
lgtm
5 years, 3 months ago (2015-09-23 03:12:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359243002/1
5 years, 3 months ago (2015-09-23 03:13:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 03:55:21 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 03:55:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f28b8c3f0895976d060159edd5271c8a6a2a92a
Cr-Commit-Position: refs/heads/master@{#350294}

Powered by Google App Engine
This is Rietveld 408576698