[GN]: Fix bug where cflag vars were not being written on non-PCH builds

tools/gn/ninja_binary_target_writer_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "tools/gn/ninja_binary_target_writer.h"
 #include "tools/gn/scheduler.h"
 #include "tools/gn/target.h"
@@ skipping 391 matching lines @@
   pch_toolchain.ToolchainSetupComplete();
 
   // This target doesn't specify precompiled headers.
   {
     Target no_pch_target(&pch_settings,
                          Label(SourceDir("//foo/"), "no_pch_target"));
     no_pch_target.set_output_type(Target::SOURCE_SET);
     no_pch_target.visibility().SetPublic();
     no_pch_target.sources().push_back(SourceFile("//foo/input1.cc"));
     no_pch_target.sources().push_back(SourceFile("//foo/input2.c"));
+    no_pch_target.config_values().cflags_c().push_back("-std=c99");
     no_pch_target.SetToolchain(&pch_toolchain);
     ASSERT_TRUE(no_pch_target.OnResolved(&err));
 
     std::ostringstream out;
     NinjaBinaryTargetWriter writer(&no_pch_target, out);
     writer.Run();
 
     const char no_pch_expected[] =
         "defines =\n"
         "include_dirs =\n"
         "cflags =\n"
-        "cflags_c =\n"
+        "cflags_c = -std=c99\n"
         "cflags_cc =\n"
         "target_output_name = no_pch_target\n"
         "\n"
         "build withpch/obj/foo/no_pch_target.input1.o: "
                "withpch_cxx ../../foo/input1.cc\n"
         "build withpch/obj/foo/no_pch_target.input2.o: "
                "withpch_cc ../../foo/input2.c\n"
         "\n"
         "build withpch/obj/foo/no_pch_target.stamp: "
                "withpch_stamp withpch/obj/foo/no_pch_target.input1.o "
@@ skipping 96 matching lines @@
   pch_toolchain.ToolchainSetupComplete();
 
   // This target doesn't specify precompiled headers.
   {
     Target no_pch_target(&pch_settings,
                          Label(SourceDir("//foo/"), "no_pch_target"));
     no_pch_target.set_output_type(Target::SOURCE_SET);
     no_pch_target.visibility().SetPublic();
     no_pch_target.sources().push_back(SourceFile("//foo/input1.cc"));
     no_pch_target.sources().push_back(SourceFile("//foo/input2.c"));
+    no_pch_target.config_values().cflags_c().push_back("-std=c99");
     no_pch_target.SetToolchain(&pch_toolchain);
     ASSERT_TRUE(no_pch_target.OnResolved(&err));
 
     std::ostringstream out;
     NinjaBinaryTargetWriter writer(&no_pch_target, out);
     writer.Run();
 
     const char no_pch_expected[] =
         "defines =\n"
         "include_dirs =\n"
         "cflags =\n"
-        "cflags_c =\n"
+        "cflags_c = -std=c99\n"
         "cflags_cc =\n"
         "target_output_name = no_pch_target\n"
         "\n"
         "build withpch/obj/foo/no_pch_target.input1.o: "
                "withpch_cxx ../../foo/input1.cc\n"
         "build withpch/obj/foo/no_pch_target.input2.o: "
                "withpch_cc ../../foo/input2.c\n"
         "\n"
         "build withpch/obj/foo/no_pch_target.stamp: "
                "withpch_stamp withpch/obj/foo/no_pch_target.input1.o "
@@ skipping 66 matching lines @@
 
   EXPECT_FALSE(scheduler.is_failed());
 
   std::ostringstream out;
   NinjaBinaryTargetWriter writer(&target, out);
   writer.Run();
 
   // Should have issued an error.
   EXPECT_TRUE(scheduler.is_failed());
 }