tools/gn/variables.h - Issue 1359243002: [GN]: Fix bug where cflag vars were not being written on non-PCH builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/variables.h

Issue 1359243002: [GN]: Fix bug where cflag vars were not being written on non-PCH builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/variables.h

diff --git a/tools/gn/variables.h b/tools/gn/variables.h

index 65d57a8ef3f2bb83d211480e5ca9c28cc1f4c90b..4d8c4b4c297aa6d4bd3279bd69799c3541bf86b7 100644

--- a/tools/gn/variables.h

+++ b/tools/gn/variables.h

@@ -103,22 +103,6 @@ extern const char kCflagsObjCC[];

extern const char kCflagsObjCC_HelpShort[];

extern const char* kCflagsObjCC_Help;

-extern const char kCflagsPCHC[];

-extern const char kCflagsPCHC_HelpShort[];

-extern const char* kCflagsPCHC_Help;

-extern const char kCflagsPCHCC[];

-extern const char kCflagsPCHCC_HelpShort[];

-extern const char* kCflagsPCHCC_Help;

-extern const char kCflagsPCHObjC[];

-extern const char kCflagsPCHObjC_HelpShort[];

-extern const char* kCflagsPCHObjC_Help;

-extern const char kCflagsPCHObjCC[];

-extern const char kCflagsPCHObjCC_HelpShort[];

-extern const char* kCflagsPCHObjCC_Help;

extern const char kCheckIncludes[];

extern const char kCheckIncludes_HelpShort[];

extern const char kCheckIncludes_Help[];

« no previous file with comments | « tools/gn/ninja_binary_target_writer_unittest.cc ('k') | no next file » | no next file with comments »