tools/gn/ninja_binary_target_writer.cc - Issue 1359243002: [GN]: Fix bug where cflag vars were not being written on non-PCH builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 1359243002: [GN]: Fix bug where cflag vars were not being written on non-PCH builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_binary_target_writer.cc

diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc

index 1a6fe5bedc767060096d57c294f91e42ede01e8c..3a08e57964e9cbb367cfaa2e820fdb100a1fbbe2 100644

--- a/tools/gn/ninja_binary_target_writer.cc

+++ b/tools/gn/ninja_binary_target_writer.cc

@@ -492,6 +492,9 @@ void NinjaBinaryTargetWriter::WriteOneFlag(

out_ << " -include " << pch_file;

}

+ } else {

+ RecursiveTargetConfigStringsToStream(target_, getter,

+ flag_escape_options, out_);

}

out_ << std::endl;

}

« no previous file with comments | « no previous file | tools/gn/ninja_binary_target_writer_unittest.cc » ('j') | no next file with comments »