Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1358743002: Make Get operations only serialize the bare minimum. (Closed)

Created:
5 years, 3 months ago by iannucci
Modified:
5 years, 3 months ago
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@fix_time
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Make Get operations only serialize the bare minimum. Now PropertyLoadSaver has GetAllMeta, which is like Save, except that it ONLY returns the metadata. This avoids situations where zero-initialized structs aren't expecting to be serialized for a nominally write-only operation (e.g. Get). R=dnj@chromium.org, estaab@chromium.org, maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org BUG=https://github.com/luci/gae/issues/11 Committed: https://github.com/luci/gae/commit/7a266a26bb3caafe1029ed532fc8472c47aaf6e1

Patch Set 1 #

Patch Set 2 : PropertyMap should always copy on save-out functions to avoid external mutation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -31 lines) Patch
M service/datastore/datastore.go View 2 chunks +2 lines, -2 lines 0 comments Download
M service/datastore/datastore_test.go View 3 chunks +18 lines, -2 lines 0 comments Download
M service/datastore/multiarg.go View 6 chunks +30 lines, -7 lines 0 comments Download
M service/datastore/pls_impl.go View 3 chunks +25 lines, -20 lines 0 comments Download
M service/datastore/pls_test.go View 2 chunks +2 lines, -0 lines 0 comments Download
M service/datastore/properties.go View 1 2 chunks +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1345043005 Patch 1

Messages

Total messages: 5 (1 generated)
iannucci
5 years, 3 months ago (2015-09-19 06:34:54 UTC) #1
Vadim Sh.
lgtm
5 years, 3 months ago (2015-09-19 20:01:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358743002/20001
5 years, 3 months ago (2015-09-19 20:01:59 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-19 20:03:26 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/7a266a26bb3caafe1029ed532fc8472c47aaf6e1

Powered by Google App Engine
This is Rietveld 408576698