Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: service/datastore/datastore.go

Issue 1358743002: Make Get operations only serialize the bare minimum. (Closed) Base URL: https://github.com/luci/gae.git@fix_time
Patch Set: PropertyMap should always copy on save-out functions to avoid external mutation Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | service/datastore/datastore_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/datastore.go
diff --git a/service/datastore/datastore.go b/service/datastore/datastore.go
index adcffad20740344a72b03f71ab892c71b755e03b..195df7871a2604d741010175a8f4636b9b64f109 100644
--- a/service/datastore/datastore.go
+++ b/service/datastore/datastore.go
@@ -199,7 +199,7 @@ func (d *datastoreImpl) GetMulti(dst interface{}) error {
return fmt.Errorf("invalid GetMulti input type: %T", dst)
}
- keys, pms, err := mat.GetKeysPMs(d.aid, d.ns, slice)
+ keys, pms, err := mat.GetKeysPMs(d.aid, d.ns, slice, true)
if err != nil {
return err
}
@@ -227,7 +227,7 @@ func (d *datastoreImpl) PutMulti(src interface{}) error {
return fmt.Errorf("invalid PutMulti input type: %T", src)
}
- keys, vals, err := mat.GetKeysPMs(d.aid, d.ns, slice)
+ keys, vals, err := mat.GetKeysPMs(d.aid, d.ns, slice, false)
if err != nil {
return err
}
« no previous file with comments | « no previous file | service/datastore/datastore_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698