Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2013)

Unified Diff: service/datastore/pls_test.go

Issue 1358743002: Make Get operations only serialize the bare minimum. (Closed) Base URL: https://github.com/luci/gae.git@fix_time
Patch Set: PropertyMap should always copy on save-out functions to avoid external mutation Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « service/datastore/pls_impl.go ('k') | service/datastore/properties.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/pls_test.go
diff --git a/service/datastore/pls_test.go b/service/datastore/pls_test.go
index ad7e1e71d87cd290e17e8247e116717b91abb52b..3ec9867f9d91e750d41bd2d4d1e56b139d1559ca 100644
--- a/service/datastore/pls_test.go
+++ b/service/datastore/pls_test.go
@@ -375,6 +375,7 @@ func (d *Doubler) Save(withMeta bool) (PropertyMap, error) {
return propMap, nil
}
+func (d *Doubler) GetAllMeta() PropertyMap { return nil }
func (d *Doubler) GetMeta(string) (interface{}, error) { return nil, ErrMetaFieldUnset }
func (d *Doubler) GetMetaDefault(_ string, dflt interface{}) interface{} { return dflt }
func (d *Doubler) SetMeta(string, interface{}) error { return ErrMetaFieldUnset }
@@ -403,6 +404,7 @@ func (d *Deriver) Save(withMeta bool) (PropertyMap, error) {
}, nil
}
+func (d *Deriver) GetAllMeta() PropertyMap { return nil }
func (d *Deriver) GetMeta(string) (interface{}, error) { return nil, ErrMetaFieldUnset }
func (d *Deriver) GetMetaDefault(_ string, dflt interface{}) interface{} { return dflt }
func (d *Deriver) SetMeta(string, interface{}) error { return ErrMetaFieldUnset }
« no previous file with comments | « service/datastore/pls_impl.go ('k') | service/datastore/properties.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698