Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1345043005: Fix zero time bug (Closed)

Created:
5 years, 3 months ago by iannucci
Modified:
5 years, 3 months ago
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Fix zero time bug. `time.Time{}` needs to be able to round-trip everywhere. Previously various things were implicitly adding the Local or UTC timezones, even when the time value was zero. R=vadimsh@chromium.org BUG=https://github.com/luci/gae/issues/10 Committed: https://github.com/luci/gae/commit/97f1aaf90868a9a3bc651a808ceba3247145e202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M impl/prod/raw_datastore_type_converter.go View 1 chunk +5 lines, -1 line 0 comments Download
M impl/prod/raw_datastore_type_converter_test.go View 2 chunks +15 lines, -2 lines 0 comments Download
M service/datastore/properties.go View 3 chunks +10 lines, -3 lines 0 comments Download
M service/datastore/serialize/serialize.go View 1 chunk +5 lines, -1 line 0 comments Download
M service/datastore/serialize/serialize_test.go View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
iannucci
5 years, 3 months ago (2015-09-19 05:53:29 UTC) #1
iannucci
On 2015/09/19 at 05:53:29, iannucci wrote: > + moar ppls
5 years, 3 months ago (2015-09-19 18:27:04 UTC) #3
dnj (Google)
lgtm
5 years, 3 months ago (2015-09-19 18:31:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345043005/1
5 years, 3 months ago (2015-09-19 19:03:27 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-19 19:04:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/97f1aaf90868a9a3bc651a808ceba3247145e202

Powered by Google App Engine
This is Rietveld 408576698