Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135833002: Add missing virtual keyword for methods with OVERRIDE (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, shans, eae+blinkwatch, nessy, adamk+blink_chromium.org, pdr, Steve Block, dino_apple.com, rwlbuis, Nils Barth (inactive), jamesr, Nate Chapin, arv+blink, alancutter (OOO until 2018), marja+watch_chromium.org, dsinclair, dglazkov+blink, abarth-chromium, danakj, dstockwell, Timothy Loh, Rik, jchaffraix+rendering, pdr., Eric Willigers, philipj_slow, rjwright, zoltan1, sof, jbroman, feature-media-reviews_chromium.org, krit, darktears, kojih, vcarbune.chromium, jsbell+bindings_chromium.org, bemjb+rendering_chromium.org, gasubic, leviw+renderwatch, Mike Lawther (Google), f(malita), Inactive, Stephen Chennney
Visibility:
Public.

Description

Add missing virtual keyword for methods with OVERRIDE Several methods are marked as OVERRIDE but they are missing the virtual keyword. This CL explicitly marks those methods as virtual for clarity. R=eseidel, esprehn BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M Source/bindings/v8/CallbackPromiseAdapter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimationsTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/TimedItemTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/MessagePort.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CreateLinkCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlsChromium.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEColorMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEComponentTransfer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEDisplacementMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEFlood.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/test/MockDiscardablePixelRef.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 11 months ago (2014-01-12 01:17:46 UTC) #1
haraken
LGTM (though I'm not an OWNER of platform/)
6 years, 11 months ago (2014-01-12 02:47:14 UTC) #2
abarth-chromium
platform/ LGTM
6 years, 11 months ago (2014-01-12 02:50:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135833002/1
6 years, 11 months ago (2014-01-12 02:50:38 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 00:57:45 UTC) #5
Message was sent while issue was closed. 
Change committed as 164943

Powered by Google App Engine
This is Rietveld 408576698