Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: Source/core/dom/MessagePort.h

Issue 135833002: Add missing virtual keyword for methods with OVERRIDE (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/animation/TimedItemTest.cpp ('k') | Source/core/dom/SelectorQuery.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 // Returns 0 if there is an exception, or if the passed-in array is 0/empty. 77 // Returns 0 if there is an exception, or if the passed-in array is 0/empty.
78 static PassOwnPtr<MessagePortChannelArray> disentanglePorts(const MessagePor tArray*, ExceptionState&); 78 static PassOwnPtr<MessagePortChannelArray> disentanglePorts(const MessagePor tArray*, ExceptionState&);
79 79
80 // Returns 0 if the passed array is 0/empty. 80 // Returns 0 if the passed array is 0/empty.
81 static PassOwnPtr<MessagePortArray> entanglePorts(ExecutionContext&, PassOwn Ptr<MessagePortChannelArray>); 81 static PassOwnPtr<MessagePortArray> entanglePorts(ExecutionContext&, PassOwn Ptr<MessagePortChannelArray>);
82 82
83 bool started() const { return m_started; } 83 bool started() const { return m_started; }
84 84
85 virtual const AtomicString& interfaceName() const OVERRIDE; 85 virtual const AtomicString& interfaceName() const OVERRIDE;
86 virtual ExecutionContext* executionContext() const OVERRIDE { return ActiveD OMObject::executionContext(); } 86 virtual ExecutionContext* executionContext() const OVERRIDE { return ActiveD OMObject::executionContext(); }
87 MessagePort* toMessagePort() OVERRIDE { return this; } 87 virtual MessagePort* toMessagePort() OVERRIDE { return this; }
88 88
89 // ActiveDOMObject implementation. 89 // ActiveDOMObject implementation.
90 virtual bool hasPendingActivity() const OVERRIDE; 90 virtual bool hasPendingActivity() const OVERRIDE;
91 virtual void stop() OVERRIDE { close(); } 91 virtual void stop() OVERRIDE { close(); }
92 92
93 void setOnmessage(PassRefPtr<EventListener> listener, DOMWrapperWorld* world ) 93 void setOnmessage(PassRefPtr<EventListener> listener, DOMWrapperWorld* world )
94 { 94 {
95 setAttributeEventListener(EventTypeNames::message, listener, world); 95 setAttributeEventListener(EventTypeNames::message, listener, world);
96 start(); 96 start();
97 } 97 }
(...skipping 16 matching lines...) Expand all
114 114
115 bool m_started; 115 bool m_started;
116 bool m_closed; 116 bool m_closed;
117 117
118 WeakPtrFactory<MessagePort> m_weakFactory; 118 WeakPtrFactory<MessagePort> m_weakFactory;
119 }; 119 };
120 120
121 } // namespace WebCore 121 } // namespace WebCore
122 122
123 #endif // MessagePort_h 123 #endif // MessagePort_h
OLDNEW
« no previous file with comments | « Source/core/animation/TimedItemTest.cpp ('k') | Source/core/dom/SelectorQuery.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698