Source/bindings/v8/CallbackPromiseAdapter.h - Issue 135833002: Add missing virtual keyword for methods with OVERRIDE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/CallbackPromiseAdapter.h

Issue 135833002: Add missing virtual keyword for methods with OVERRIDE (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/CallbackPromiseAdapter.h

diff --git a/Source/bindings/v8/CallbackPromiseAdapter.h b/Source/bindings/v8/CallbackPromiseAdapter.h

index e4862d473559f9651e3c0aafcc58de23c4734e54..f8a36a637b5ba01e27ac3500f95a4e234b0eb3ce 100644

--- a/Source/bindings/v8/CallbackPromiseAdapter.h

+++ b/Source/bindings/v8/CallbackPromiseAdapter.h

@@ -75,7 +75,7 @@ public:

DOMRequestState::Scope scope(m_requestState);

m_resolver->resolve(S::from(result));

}

- void onError(typename T::WebType* error) OVERRIDE

+ virtual void onError(typename T::WebType* error) OVERRIDE

{

DOMRequestState::Scope scope(m_requestState);

m_resolver->reject(T::from(error));

« no previous file with comments | « no previous file | Source/core/animation/CompositorAnimationsTestHelper.h » ('j') | no next file with comments »