Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: Source/core/svg/animation/SVGSMILElement.h

Issue 135833002: Add missing virtual keyword for methods with OVERRIDE (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 void addBeginTime(SMILTime eventTime, SMILTime endTime, SMILTimeWithOrigin:: Origin = SMILTimeWithOrigin::ParserOrigin); 119 void addBeginTime(SMILTime eventTime, SMILTime endTime, SMILTimeWithOrigin:: Origin = SMILTimeWithOrigin::ParserOrigin);
120 void addEndTime(SMILTime eventTime, SMILTime endTime, SMILTimeWithOrigin::Or igin = SMILTimeWithOrigin::ParserOrigin); 120 void addEndTime(SMILTime eventTime, SMILTime endTime, SMILTimeWithOrigin::Or igin = SMILTimeWithOrigin::ParserOrigin);
121 121
122 void setInactive() { m_activeState = Inactive; } 122 void setInactive() { m_activeState = Inactive; }
123 123
124 // Sub-classes may need to take action when the target is changed. 124 // Sub-classes may need to take action when the target is changed.
125 virtual void setTargetElement(SVGElement*); 125 virtual void setTargetElement(SVGElement*);
126 virtual void setAttributeName(const QualifiedName&); 126 virtual void setAttributeName(const QualifiedName&);
127 127
128 private: 128 private:
129 void buildPendingResource() OVERRIDE; 129 virtual void buildPendingResource() OVERRIDE;
130 void clearResourceAndEventBaseReferences(); 130 void clearResourceAndEventBaseReferences();
131 131
132 virtual void startedActiveInterval() = 0; 132 virtual void startedActiveInterval() = 0;
133 void endedActiveInterval(); 133 void endedActiveInterval();
134 virtual void updateAnimation(float percent, unsigned repeat, SVGSMILElement* resultElement) = 0; 134 virtual void updateAnimation(float percent, unsigned repeat, SVGSMILElement* resultElement) = 0;
135 135
136 virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE { return false; } 136 virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE { return false; }
137 137
138 enum BeginOrEnd { 138 enum BeginOrEnd {
139 Begin, 139 Begin,
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 { 241 {
242 return node.hasTagName(SVGNames::setTag) || node.hasTagName(SVGNames::animat eTag) || node.hasTagName(SVGNames::animateMotionTag) 242 return node.hasTagName(SVGNames::setTag) || node.hasTagName(SVGNames::animat eTag) || node.hasTagName(SVGNames::animateMotionTag)
243 || node.hasTagName(SVGNames::animateTransformTag) || node.hasTagName(SVG Names::animateColorTag); 243 || node.hasTagName(SVGNames::animateTransformTag) || node.hasTagName(SVG Names::animateColorTag);
244 } 244 }
245 245
246 DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION(SVGSMILElement); 246 DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION(SVGSMILElement);
247 247
248 } 248 }
249 249
250 #endif // SVGSMILElement_h 250 #endif // SVGSMILElement_h
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/RenderSVGModelObject.h ('k') | Source/platform/graphics/filters/FEColorMatrix.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698