Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1356743003: Revert of Check for CloseHandle failures even when not debugging (Closed)

Created:
5 years, 3 months ago by brucedawson
Modified:
5 years, 3 months ago
CC:
chromium-reviews, grt+watch_chromium.org, gavinp+memory_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Check for CloseHandle failures even when not debugging (patchset #4 id:60001 of https://codereview.chromium.org/1350493002/ ) Reason for revert: The SharedMemory checks are causing CHECK crashes in the printing system. See bug 533310. Reverting to allow time for an investigation of that underlying problem. Original issue's description: > Check for CloseHandle failures even when not debugging > > Bug 524267 was a handle closing failure that only showed up when running > renderer processes under a debugger at startup, so it was not discovered > for a while. > > Similarly, bug 520305 is a long-standing base_unittests bug that only > shows up under a debugger. > > This change fixes 520305 and checks for many handle closing failures > always so that subsequent bugs of this type will be detected > immediately. > > Most of the CloseHandle calls in base are now checked. > > This replaces the uncommitted https://codereview.chromium.org/1343873002/ > > R=grt@chromium.org,rvargas@chromium.org,dalecurtis@chromium.org > BUG=524267, 520305 > > Committed: https://crrev.com/9ae49a753d07f5a9266a63a89e7336d774f3fe37 > Cr-Commit-Position: refs/heads/master@{#349333} TBR=dalecurtis@chromium.org,grt@chromium.org,rvargas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524267, 520305 Committed: https://crrev.com/d350943f049ddcf83b371cf97d652d4d6a8f4f18 Cr-Commit-Position: refs/heads/master@{#349716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -37 lines) Patch
M base/files/file_util_win.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M base/memory/shared_memory_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/process/kill_win.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M base/sync_socket_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M base/sync_socket_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/threading/platform_thread_win.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M base/time/time_win_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M base/win/object_watcher_unittest.cc View 5 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brucedawson
Created Revert of Check for CloseHandle failures even when not debugging
5 years, 3 months ago (2015-09-18 18:23:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356743003/1
5 years, 3 months ago (2015-09-18 18:24:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 18:28:21 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 18:29:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d350943f049ddcf83b371cf97d652d4d6a8f4f18
Cr-Commit-Position: refs/heads/master@{#349716}

Powered by Google App Engine
This is Rietveld 408576698