Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: base/process/kill_win.cc

Issue 1356743003: Revert of Check for CloseHandle failures even when not debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/memory/shared_memory_win.cc ('k') | base/sync_socket_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process/kill_win.cc
diff --git a/base/process/kill_win.cc b/base/process/kill_win.cc
index b35dd6321696e982580ba2704d78b4811e524ff2..0da3a26ae4f78e9af924609904e81db7872958e2 100644
--- a/base/process/kill_win.cc
+++ b/base/process/kill_win.cc
@@ -159,8 +159,11 @@
DWORD remaining_wait = static_cast<DWORD>(std::max(
static_cast<int64>(0),
wait.InMilliseconds() - (GetTickCount() - start_time)));
- Process process(Process::OpenWithAccess(entry->th32ProcessID, SYNCHRONIZE));
- DWORD wait_result = WaitForSingleObject(process.Handle(), remaining_wait);
+ HANDLE process = OpenProcess(SYNCHRONIZE,
+ FALSE,
+ entry->th32ProcessID);
+ DWORD wait_result = WaitForSingleObject(process, remaining_wait);
+ CloseHandle(process);
result &= (wait_result == WAIT_OBJECT_0);
}
« no previous file with comments | « base/memory/shared_memory_win.cc ('k') | base/sync_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698