base/sync_socket_win.cc - Issue 1356743003: Revert of Check for CloseHandle failures even when not debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/sync_socket_win.cc

Issue 1356743003: Revert of Check for CloseHandle failures even when not debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/sync_socket_win.cc

diff --git a/base/sync_socket_win.cc b/base/sync_socket_win.cc

index fb722919f6c45239810eb45c01bdfe21d0d06cdf..e5088162433f2f402a8809c1342142c028e07341 100644

--- a/base/sync_socket_win.cc

+++ b/base/sync_socket_win.cc

@@ -235,8 +235,7 @@

if (handle_ == kInvalidHandle)

return true;

- const BOOL result = ::CloseHandle(handle_);

- CHECK(result);

+ const BOOL result = CloseHandle(handle_);

handle_ = kInvalidHandle;

return result == TRUE;

}

« no previous file with comments | « base/sync_socket_unittest.cc ('k') | base/threading/platform_thread_win.cc » ('j') | no next file with comments »