| Index: base/win/object_watcher_unittest.cc
|
| diff --git a/base/win/object_watcher_unittest.cc b/base/win/object_watcher_unittest.cc
|
| index 7e83e2a83c416d994e486c817971eb02e4e63b36..b30ca41a4fe4d3f6cb37455a72ed57ed69d063e4 100644
|
| --- a/base/win/object_watcher_unittest.cc
|
| +++ b/base/win/object_watcher_unittest.cc
|
| @@ -39,19 +39,20 @@
|
| EXPECT_FALSE(watcher.IsWatching());
|
|
|
| // A manual-reset event that is not yet signaled.
|
| - base::win::ScopedHandle event(CreateEvent(NULL, TRUE, FALSE, NULL));
|
| + HANDLE event = CreateEvent(NULL, TRUE, FALSE, NULL);
|
|
|
| QuitDelegate delegate;
|
| - bool ok = watcher.StartWatching(event.Get(), &delegate);
|
| + bool ok = watcher.StartWatching(event, &delegate);
|
| EXPECT_TRUE(ok);
|
| EXPECT_TRUE(watcher.IsWatching());
|
| - EXPECT_EQ(event.Get(), watcher.GetWatchedObject());
|
| + EXPECT_EQ(event, watcher.GetWatchedObject());
|
|
|
| - SetEvent(event.Get());
|
| + SetEvent(event);
|
|
|
| MessageLoop::current()->Run();
|
|
|
| EXPECT_FALSE(watcher.IsWatching());
|
| + CloseHandle(event);
|
| }
|
|
|
| void RunTest_BasicCancel(MessageLoop::Type message_loop_type) {
|
| @@ -60,13 +61,15 @@
|
| ObjectWatcher watcher;
|
|
|
| // A manual-reset event that is not yet signaled.
|
| - base::win::ScopedHandle event(CreateEvent(NULL, TRUE, FALSE, NULL));
|
| + HANDLE event = CreateEvent(NULL, TRUE, FALSE, NULL);
|
|
|
| QuitDelegate delegate;
|
| - bool ok = watcher.StartWatching(event.Get(), &delegate);
|
| + bool ok = watcher.StartWatching(event, &delegate);
|
| EXPECT_TRUE(ok);
|
|
|
| watcher.StopWatching();
|
| +
|
| + CloseHandle(event);
|
| }
|
|
|
| void RunTest_CancelAfterSet(MessageLoop::Type message_loop_type) {
|
| @@ -78,12 +81,12 @@
|
| DecrementCountDelegate delegate(&counter);
|
|
|
| // A manual-reset event that is not yet signaled.
|
| - base::win::ScopedHandle event(CreateEvent(NULL, TRUE, FALSE, NULL));
|
| + HANDLE event = CreateEvent(NULL, TRUE, FALSE, NULL);
|
|
|
| - bool ok = watcher.StartWatching(event.Get(), &delegate);
|
| + bool ok = watcher.StartWatching(event, &delegate);
|
| EXPECT_TRUE(ok);
|
|
|
| - SetEvent(event.Get());
|
| + SetEvent(event);
|
|
|
| // Let the background thread do its business
|
| Sleep(30);
|
| @@ -94,6 +97,8 @@
|
|
|
| // Our delegate should not have fired.
|
| EXPECT_EQ(1, counter);
|
| +
|
| + CloseHandle(event);
|
| }
|
|
|
| void RunTest_SignalBeforeWatch(MessageLoop::Type message_loop_type) {
|
| @@ -102,32 +107,33 @@
|
| ObjectWatcher watcher;
|
|
|
| // A manual-reset event that is signaled before we begin watching.
|
| - base::win::ScopedHandle event(CreateEvent(NULL, TRUE, TRUE, NULL));
|
| + HANDLE event = CreateEvent(NULL, TRUE, TRUE, NULL);
|
|
|
| QuitDelegate delegate;
|
| - bool ok = watcher.StartWatching(event.Get(), &delegate);
|
| + bool ok = watcher.StartWatching(event, &delegate);
|
| EXPECT_TRUE(ok);
|
|
|
| MessageLoop::current()->Run();
|
|
|
| EXPECT_FALSE(watcher.IsWatching());
|
| + CloseHandle(event);
|
| }
|
|
|
| void RunTest_OutlivesMessageLoop(MessageLoop::Type message_loop_type) {
|
| // Simulate a MessageLoop that dies before an ObjectWatcher. This ordinarily
|
| // doesn't happen when people use the Thread class, but it can happen when
|
| // people use the Singleton pattern or atexit.
|
| - // Note that |event| is not signaled
|
| - base::win::ScopedHandle event(CreateEvent(NULL, TRUE, FALSE, NULL));
|
| + HANDLE event = CreateEvent(NULL, TRUE, FALSE, NULL); // not signaled
|
| {
|
| ObjectWatcher watcher;
|
| {
|
| MessageLoop message_loop(message_loop_type);
|
|
|
| QuitDelegate delegate;
|
| - watcher.StartWatching(event.Get(), &delegate);
|
| + watcher.StartWatching(event, &delegate);
|
| }
|
| }
|
| + CloseHandle(event);
|
| }
|
|
|
| } // namespace
|
|
|