Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1356563003: Merge to XFA: Ensure functions in FXJS_V8 are prefixed by FXJS_. (Closed)

Created:
5 years, 3 months ago by Tom Sepez
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Ensure functions in FXJS_V8 are prefixed by FXJS_. Manual edits: fpdfsdk/include/javascript/JS_Define.h fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp fpdfsdk/src/javascript/Document.cpp fpdfsdk/src/javascript/JS_Runtime.cpp fpdfsdk/src/jsapi/fxjs_v8.cpp (cherry picked from commit 506df426d5d64d68e9dc27ffebcf56f6c6a1bccf) Original Review URL: https://codereview.chromium.org/1347833002 . (cherry picked from commit 455019ca48f60bd285e043986471f51f17c69a0d) Original Review URL: https://codereview.chromium.org/1349783003 . (cherry picked from commit 1af240cc45480520b447be767686e73a29c48f9e) Original Review URL: https://codereview.chromium.org/1348693003 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/39bfe122b4867601051c56562a5ab9cf6be644ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1041 lines, -1097 lines) Patch
M fpdfsdk/include/javascript/JS_Define.h View 15 chunks +82 lines, -81 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/JS_Value.h View 4 chunks +30 lines, -5 lines 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 3 chunks +150 lines, -168 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Consts.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 14 chunks +54 lines, -54 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 3 chunks +8 lines, -15 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_EventHandler.cpp View 3 chunks +14 lines, -18 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 8 chunks +30 lines, -30 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 22 chunks +335 lines, -57 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 10 chunks +48 lines, -45 lines 0 comments Download
M fpdfsdk/src/javascript/event.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 10 chunks +78 lines, -81 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 32 chunks +191 lines, -523 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, for review.
5 years, 3 months ago (2015-09-17 19:06:17 UTC) #2
Lei Zhang
Did all 3 CLs cherry-pick cleanly?
5 years, 3 months ago (2015-09-17 20:34:45 UTC) #3
Lei Zhang
On 2015/09/17 20:34:45, Lei Zhang wrote: > Did all 3 CLs cherry-pick cleanly? Oh, I ...
5 years, 3 months ago (2015-09-17 20:35:02 UTC) #4
Lei Zhang
lgtm
5 years, 3 months ago (2015-09-17 20:39:17 UTC) #5
Tom Sepez
5 years, 3 months ago (2015-09-17 22:25:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
39bfe122b4867601051c56562a5ab9cf6be644ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698