Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1347833002: Ensure functions in FXJS_V8 are prefixed by FXJS_. (Closed)

Created:
5 years, 3 months ago by Tom Sepez
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure functions in FXJS_V8 are prefixed by FXJS_. Currently, its hard to tell which functions come from the JS_ layer at fpdfsdk/include/javascript vs. which functions come from the FXJS_V8 layer at fpdfsdk/include/jsapi. Until we take up the task of using namespaces, at least make the prefix consistent. Move objects out of FXJS_V8 that are really part of JS_. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/506df426d5d64d68e9dc27ffebcf56f6c6a1bccf

Patch Set 1 #

Patch Set 2 : Remove stray files. #

Total comments: 7

Patch Set 3 : Rebase, nits, format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1053 lines, -1059 lines) Patch
M fpdfsdk/include/javascript/JS_Define.h View 1 2 15 chunks +82 lines, -81 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/JS_Value.h View 4 chunks +30 lines, -5 lines 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 2 3 chunks +154 lines, -168 lines 0 comments Download
M fpdfsdk/src/javascript/Consts.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 13 chunks +51 lines, -50 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 3 chunks +8 lines, -15 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_EventHandler.cpp View 3 chunks +14 lines, -18 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 7 chunks +30 lines, -29 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 1 2 22 chunks +331 lines, -57 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 10 chunks +48 lines, -45 lines 0 comments Download
M fpdfsdk/src/javascript/event.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 10 chunks +78 lines, -81 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 35 chunks +207 lines, -491 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Tom Sepez
Lei, next steps for review.
5 years, 3 months ago (2015-09-15 21:58:47 UTC) #1
Tom Sepez
Actually add Lei.
5 years, 3 months ago (2015-09-15 21:59:04 UTC) #3
Tom Sepez
https://codereview.chromium.org/1347833002/diff/20001/fpdfsdk/include/jsapi/fxjs_v8.h File fpdfsdk/include/jsapi/fxjs_v8.h (left): https://codereview.chromium.org/1347833002/diff/20001/fpdfsdk/include/jsapi/fxjs_v8.h#oldcode129 fpdfsdk/include/jsapi/fxjs_v8.h:129: unsigned JS_CalcHash(const wchar_t* main, unsigned nLen); note: One hash ...
5 years, 3 months ago (2015-09-15 22:00:50 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/1347833002/diff/20001/fpdfsdk/include/jsapi/fxjs_v8.h File fpdfsdk/include/jsapi/fxjs_v8.h (right): https://codereview.chromium.org/1347833002/diff/20001/fpdfsdk/include/jsapi/fxjs_v8.h#newcode57 fpdfsdk/include/jsapi/fxjs_v8.h:57: // as part of FXJS_ReleaseRunime(). Runime again. https://codereview.chromium.org/1347833002/diff/20001/fpdfsdk/src/javascript/JS_Value.cpp ...
5 years, 3 months ago (2015-09-15 23:18:43 UTC) #5
Tom Sepez
https://codereview.chromium.org/1347833002/diff/20001/fpdfsdk/include/jsapi/fxjs_v8.h File fpdfsdk/include/jsapi/fxjs_v8.h (right): https://codereview.chromium.org/1347833002/diff/20001/fpdfsdk/include/jsapi/fxjs_v8.h#newcode57 fpdfsdk/include/jsapi/fxjs_v8.h:57: // as part of FXJS_ReleaseRunime(). On 2015/09/15 23:18:43, Lei ...
5 years, 3 months ago (2015-09-16 17:41:31 UTC) #6
Tom Sepez
5 years, 3 months ago (2015-09-16 17:42:12 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
506df426d5d64d68e9dc27ffebcf56f6c6a1bccf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698