Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1823)

Issue 1349783003: Fix build broken at 506df426d5d6. (Closed)

Created:
5 years, 3 months ago by Tom Sepez
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix build broken at 506df426d5d6. Move header file includes when usage moved. Windows-only section missing a ")". TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/455019ca48f60bd285e043986471f51f17c69a0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M fpdfsdk/src/javascript/JS_Value.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR, red tree.
5 years, 3 months ago (2015-09-16 18:00:29 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 455019ca48f60bd285e043986471f51f17c69a0d (tree was closed).
5 years, 3 months ago (2015-09-16 18:00:42 UTC) #2
Lei Zhang
5 years, 3 months ago (2015-09-16 19:22:05 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698