Issue 1348693003: Remove several dead functions from fxjs_v8.{cpp,h}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1348693003: Remove several dead functions from fxjs_v8.{cpp,h} (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove several dead functions from fxjs_v8.{cpp,h}. Re-arrange things in the header so function overloads are next to each other, and related things are near each other. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/1af240cc45480520b447be767686e73a29c48f9e

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -59 lines)			Patch
	M	fpdfsdk/include/jsapi/fxjs_v8.h	View		3 chunks	+12 lines, -16 lines	0 comments	Download
	M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View		4 chunks	+0 lines, -43 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 3 months ago (2015-09-16 22:16:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1af240cc45480520b447be767686e73a29c48f9e (presubmit successful).