Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1356463002: Revert of cc: Implement shared worker contexts. (Closed)

Created:
5 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 3 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Implement shared worker contexts. (patchset #9 id:160001 of https://codereview.chromium.org/1336733002/ ) Reason for revert: Broke GPU rasterization on Mac OS; please see https://code.google.com/p/chromium/issues/detail?id=523411#c26 . I'm really sorry -- I don't know how this got past the CQ. Original issue's description: > cc: Implement shared worker contexts. > > This moves the responsibility to call BindToCurrentThread/SetupLock out > of cc::OutputSurface and to the maintainer of the (possibly) shared > context. > > OutputSurface now needs to be destroyed on the same thread they > were created. OutputSurface::DetachFromClient() can be used to > destroy any resources that need to be destroyed on the thread > that the OutputSurface has been bound to. > > BUG=523411 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/a47ef41ea03d3a5b8965eb700b682ddf8a1f055a > Cr-Commit-Position: refs/heads/master@{#349274} TBR=danakj@chromium.org,piman@chromium.org,sievers@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=523411 Committed: https://crrev.com/d29c2783db449ea8c802423887fa4669abb453d5 Cr-Commit-Position: refs/heads/master@{#349313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -404 lines) Patch
M cc/layers/delegated_renderer_layer_impl_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M cc/layers/nine_patch_layer_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/picture_image_layer_impl_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/layers/picture_layer_impl_perftest.cc View 3 chunks +1 line, -3 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 7 chunks +7 lines, -16 lines 0 comments Download
M cc/layers/texture_layer_unittest.cc View 3 chunks +1 line, -3 lines 0 comments Download
M cc/layers/ui_resource_layer_impl_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M cc/output/context_provider.h View 3 chunks +5 lines, -9 lines 0 comments Download
M cc/output/output_surface.h View 3 chunks +2 lines, -8 lines 0 comments Download
M cc/output/output_surface.cc View 4 chunks +12 lines, -19 lines 0 comments Download
M cc/raster/tile_task_worker_pool_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/test/fake_output_surface.h View 3 chunks +8 lines, -10 lines 0 comments Download
M cc/test/fake_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_test_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_test_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/test_context_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/test/test_context_provider.cc View 1 chunk +1 line, -14 lines 0 comments Download
M cc/tiles/tile_manager_perftest.cc View 3 chunks +1 line, -3 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 6 chunks +6 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +0 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 2 chunks +1 line, -11 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 8 chunks +14 lines, -28 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 10 chunks +22 lines, -32 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +1 line, -17 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M cc/trees/occlusion_tracker_perftest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/trees/proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/thread_proxy.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 3 chunks +3 lines, -36 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 4 chunks +16 lines, -14 lines 0 comments Download
M content/renderer/gpu/mailbox_output_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/mailbox_output_surface.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 2 chunks +7 lines, -25 lines 0 comments Download
M ui/compositor/test/in_process_context_provider.h View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Created Revert of cc: Implement shared worker contexts.
5 years, 3 months ago (2015-09-17 01:41:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356463002/1
5 years, 3 months ago (2015-09-17 01:41:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 01:43:10 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 01:43:48 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d29c2783db449ea8c802423887fa4669abb453d5
Cr-Commit-Position: refs/heads/master@{#349313}

Powered by Google App Engine
This is Rietveld 408576698