Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1355713004: Drop virtual LightSource::create (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Drop virtual LightSource::create Not used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M Source/platform/graphics/filters/DistantLightSource.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/platform/graphics/filters/LightSource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/PointLightSource.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/platform/graphics/filters/SpotLightSource.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
Remove _all_ the things! (At least that's what it's starting to feel like...) Looks like ...
5 years, 3 months ago (2015-09-21 14:45:27 UTC) #2
Stephen White
LGTM
5 years, 3 months ago (2015-09-21 15:17:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355713004/1
5 years, 3 months ago (2015-09-21 16:13:14 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 18:40:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202593

Powered by Google App Engine
This is Rietveld 408576698