Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135563004: Nukes MessageLoop::Dispatcher (2) (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 10 months ago
CC:
chromium-reviews, rjkroege, ozone-reviews_chromium.org, sadrul, tfarina, ben+aura_chromium.org, dcheng, oshima+watch_chromium.org, kalyank, ben+views_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Nukes MessageLoop::Dispatcher (2) There is no point in this typedef now that MessagePumpDispatcher is its own class. BUG=none TEST=none R=darin@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245387

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -60 lines) Patch
M ash/accelerators/accelerator_dispatcher.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/accelerators/accelerator_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/nested_dispatcher_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/nested_dispatcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/nested_dispatcher_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_loop.h View 3 chunks +1 line, -4 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M base/run_loop.h View 3 chunks +7 lines, -3 lines 1 comment Download
M base/run_loop.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_dialog.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/simple_message_box_views.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/user_data_dir_dialog_view.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/display/output_configurator.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/aura/client/dispatcher_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/dispatcher_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/env.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/env.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/root_window_host_ozone.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/root_window_host_x11.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/accelerator_handler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_dispatcher_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_dispatcher_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
First patch was reverted because I missed updated a test. First patch is what you ...
6 years, 11 months ago (2014-01-16 20:18:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/135563004/30001
6 years, 11 months ago (2014-01-16 20:18:55 UTC) #2
commit-bot: I haz the power
Change committed as 245387
6 years, 11 months ago (2014-01-17 00:10:32 UTC) #3
darin (slow to review)
belated LGTM
6 years, 10 months ago (2014-01-31 00:24:33 UTC) #4
tfarina
https://codereview.chromium.org/135563004/diff/30001/base/run_loop.h File base/run_loop.h (right): https://codereview.chromium.org/135563004/diff/30001/base/run_loop.h#newcode11 base/run_loop.h:11: #include "base/message_loop/message_loop.h" we can remove this include now.
6 years, 10 months ago (2014-02-01 03:25:50 UTC) #5
tfarina
6 years, 10 months ago (2014-02-01 03:25:50 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/135563004/diff/30001/base/run_loop.h
File base/run_loop.h (right):

https://codereview.chromium.org/135563004/diff/30001/base/run_loop.h#newcode11
base/run_loop.h:11: #include "base/message_loop/message_loop.h"
we can remove this include now.

Powered by Google App Engine
This is Rietveld 408576698