Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: base/run_loop.h

Issue 135563004: Nukes MessageLoop::Dispatcher (2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/message_loop/message_loop_unittest.cc ('k') | base/run_loop.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_RUN_LOOP_H_ 5 #ifndef BASE_RUN_LOOP_H_
6 #define BASE_RUN_LOOP_H_ 6 #define BASE_RUN_LOOP_H_
7 7
8 #include "base/base_export.h" 8 #include "base/base_export.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
11 #include "base/message_loop/message_loop.h" 11 #include "base/message_loop/message_loop.h"
tfarina 2014/02/01 03:25:50 we can remove this include now.
12 12
13 namespace base { 13 namespace base {
14 #if defined(OS_ANDROID) 14 #if defined(OS_ANDROID)
15 class MessagePumpForUI; 15 class MessagePumpForUI;
16 #endif 16 #endif
17 17
18 #if defined(USE_AURA)
19 class MessagePumpDispatcher;
20 #endif
21
18 #if defined(OS_IOS) 22 #if defined(OS_IOS)
19 class MessagePumpUIApplication; 23 class MessagePumpUIApplication;
20 #endif 24 #endif
21 25
22 // Helper class to Run a nested MessageLoop. Please do not use nested 26 // Helper class to Run a nested MessageLoop. Please do not use nested
23 // MessageLoops in production code! If you must, use this class instead of 27 // MessageLoops in production code! If you must, use this class instead of
24 // calling MessageLoop::Run/Quit directly. RunLoop::Run can only be called once 28 // calling MessageLoop::Run/Quit directly. RunLoop::Run can only be called once
25 // per RunLoop lifetime. Create a RunLoop on the stack and call Run/Quit to run 29 // per RunLoop lifetime. Create a RunLoop on the stack and call Run/Quit to run
26 // a nested MessageLoop. 30 // a nested MessageLoop.
27 class BASE_EXPORT RunLoop { 31 class BASE_EXPORT RunLoop {
28 public: 32 public:
29 RunLoop(); 33 RunLoop();
30 #if defined(USE_AURA) 34 #if defined(USE_AURA)
31 explicit RunLoop(MessageLoop::Dispatcher* dispatcher); 35 explicit RunLoop(MessagePumpDispatcher* dispatcher);
32 #endif 36 #endif
33 ~RunLoop(); 37 ~RunLoop();
34 38
35 #if defined(USE_AURA) 39 #if defined(USE_AURA)
36 void set_dispatcher(MessageLoop::Dispatcher* dispatcher) { 40 void set_dispatcher(MessagePumpDispatcher* dispatcher) {
37 dispatcher_ = dispatcher; 41 dispatcher_ = dispatcher;
38 } 42 }
39 #endif 43 #endif
40 44
41 // Run the current MessageLoop. This blocks until Quit is called. Before 45 // Run the current MessageLoop. This blocks until Quit is called. Before
42 // calling Run, be sure to grab an AsWeakPtr or the QuitClosure in order to 46 // calling Run, be sure to grab an AsWeakPtr or the QuitClosure in order to
43 // stop the MessageLoop asynchronously. MessageLoop::Quit and QuitNow will 47 // stop the MessageLoop asynchronously. MessageLoop::Quit and QuitNow will
44 // also trigger a return from Run, but those are deprecated. 48 // also trigger a return from Run, but those are deprecated.
45 void Run(); 49 void Run();
46 50
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 // Return false to abort the Run. 93 // Return false to abort the Run.
90 bool BeforeRun(); 94 bool BeforeRun();
91 void AfterRun(); 95 void AfterRun();
92 96
93 MessageLoop* loop_; 97 MessageLoop* loop_;
94 98
95 // Parent RunLoop or NULL if this is the top-most RunLoop. 99 // Parent RunLoop or NULL if this is the top-most RunLoop.
96 RunLoop* previous_run_loop_; 100 RunLoop* previous_run_loop_;
97 101
98 #if defined(USE_AURA) 102 #if defined(USE_AURA)
99 MessageLoop::Dispatcher* dispatcher_; 103 MessagePumpDispatcher* dispatcher_;
100 #endif 104 #endif
101 105
102 // Used to count how many nested Run() invocations are on the stack. 106 // Used to count how many nested Run() invocations are on the stack.
103 int run_depth_; 107 int run_depth_;
104 108
105 bool run_called_; 109 bool run_called_;
106 bool quit_called_; 110 bool quit_called_;
107 bool running_; 111 bool running_;
108 112
109 // Used to record that QuitWhenIdle() was called on the MessageLoop, meaning 113 // Used to record that QuitWhenIdle() was called on the MessageLoop, meaning
110 // that we should quit Run once it becomes idle. 114 // that we should quit Run once it becomes idle.
111 bool quit_when_idle_received_; 115 bool quit_when_idle_received_;
112 116
113 // WeakPtrFactory for QuitClosure safety. 117 // WeakPtrFactory for QuitClosure safety.
114 base::WeakPtrFactory<RunLoop> weak_factory_; 118 base::WeakPtrFactory<RunLoop> weak_factory_;
115 119
116 DISALLOW_COPY_AND_ASSIGN(RunLoop); 120 DISALLOW_COPY_AND_ASSIGN(RunLoop);
117 }; 121 };
118 122
119 } // namespace base 123 } // namespace base
120 124
121 #endif // BASE_RUN_LOOP_H_ 125 #endif // BASE_RUN_LOOP_H_
OLDNEW
« no previous file with comments | « base/message_loop/message_loop_unittest.cc ('k') | base/run_loop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698