ui/views/controls/menu/menu_controller.cc - Issue 135563004: Nukes MessageLoop::Dispatcher (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_controller.cc

Issue 135563004: Nukes MessageLoop::Dispatcher (2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_controller.cc

diff --git a/ui/views/controls/menu/menu_controller.cc b/ui/views/controls/menu/menu_controller.cc

index 38d35e4cbace4ac1352dc2123372b4c8ca174398..cd6d3bac627c5c6004b26de6d3fb95dc60c472a5 100644

--- a/ui/views/controls/menu/menu_controller.cc

+++ b/ui/views/controls/menu/menu_controller.cc

@@ -2295,7 +2295,7 @@ View* MenuController::GetActiveMouseView() {

void MenuController::SetExitType(ExitType type) {

exit_type_ = type;

// Exit nested message loops as soon as possible. We do this as

- // MessageLoop::Dispatcher is only invoked before native events, which means

+ // MessagePumpDispatcher is only invoked before native events, which means

// its entirely possible for a Widget::CloseNow() task to be processed before

// the next native message. By using QuitNow() we ensures the nested message

// loop returns as soon as possible and avoids having deleted views classes