Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1354973006: ipc: Remove unnecessary attachment broker plumbing. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Remove unnecessary attachment broker plumbing. The original design was to pass around an instance of an attachment broker. The new design uses a single global, and no longer needs any plumbing. This CL removes the last vestiges of the plumbing. BUG=493414 Committed: https://crrev.com/30dc2811d9c106d733cea51f5600875cacba2f80 Cr-Commit-Position: refs/heads/master@{#350471}

Patch Set 1 #

Patch Set 2 : Minor fixes. #

Patch Set 3 : Rebase #

Patch Set 4 : Remoting + cloud print. #

Patch Set 5 : Compile errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -233 lines) Patch
M cloud_print/service/win/service_listener.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel.h View 1 2 3 chunks +6 lines, -23 lines 0 comments Download
M ipc/ipc_channel_common.cc View 1 2 1 chunk +10 lines, -19 lines 0 comments Download
M ipc/ipc_channel_factory.h View 2 chunks +1 line, -4 lines 0 comments Download
M ipc/ipc_channel_factory.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M ipc/ipc_channel_nacl.h View 1 chunk +1 line, -3 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 2 chunks +2 lines, -10 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_win.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_perftest_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_send_fds_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_sync_channel.h View 1 chunk +1 line, -5 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M ipc/ipc_test_base.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 2 chunks +4 lines, -17 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 8 chunks +22 lines, -38 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 1 4 chunks +6 lines, -9 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.h View 2 chunks +1 line, -4 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_mojo_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/desktop_process.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M remoting/host/ipc_util_posix.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/host/ipc_util_win.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 3 1 chunk +3 lines, -7 lines 0 comments Download
M remoting/host/win/worker_process_launcher_unittest.cc View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/host/win/wts_session_process_delegate.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 32 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354973006/1
5 years, 3 months ago (2015-09-19 01:07:23 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/43025)
5 years, 3 months ago (2015-09-19 01:35:43 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354973006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354973006/20001
5 years, 3 months ago (2015-09-19 01:51:12 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/85347)
5 years, 3 months ago (2015-09-19 02:24:41 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354973006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354973006/60001
5 years, 3 months ago (2015-09-22 19:24:59 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/86185)
5 years, 3 months ago (2015-09-22 20:30:32 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354973006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354973006/80001
5 years, 3 months ago (2015-09-22 20:56:32 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/44067)
5 years, 3 months ago (2015-09-22 21:21:52 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354973006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354973006/80001
5 years, 3 months ago (2015-09-22 21:37:02 UTC) #18
erikchen
tsepez: Please review.
5 years, 3 months ago (2015-09-22 21:59:53 UTC) #20
Tom Sepez
LGTM on code deletion.
5 years, 3 months ago (2015-09-22 22:19:56 UTC) #21
erikchen
garykac: Looking for a remoting/ review. avi: Looking for a content/ review. scottbyer: Looking for ...
5 years, 3 months ago (2015-09-22 23:14:57 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-22 23:23:19 UTC) #25
Avi (use Gerrit)
lgtm
5 years, 3 months ago (2015-09-22 23:56:22 UTC) #26
Scott Byer
LGTM for cloud print
5 years, 3 months ago (2015-09-23 21:44:06 UTC) #27
garykac
chromoting lgtm
5 years, 3 months ago (2015-09-24 01:16:57 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354973006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354973006/80001
5 years, 3 months ago (2015-09-24 01:35:47 UTC) #30
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-24 03:26:58 UTC) #31
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 03:28:40 UTC) #32
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/30dc2811d9c106d733cea51f5600875cacba2f80
Cr-Commit-Position: refs/heads/master@{#350471}

Powered by Google App Engine
This is Rietveld 408576698