cloud_print/service/win/service_listener.cc - Issue 1354973006: ipc: Remove unnecessary attachment broker plumbing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/win/service_listener.cc

Issue 1354973006: ipc: Remove unnecessary attachment broker plumbing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile errors. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cloud_print/service/win/service_listener.cc

diff --git a/cloud_print/service/win/service_listener.cc b/cloud_print/service/win/service_listener.cc

index 2fdc8b70eca5a5ce2300c7fb8bd7edcd471ec5a1..52d8ab8785d7c02a39e7e389fb848ca736fcf1f2 100644

--- a/cloud_print/service/win/service_listener.cc

+++ b/cloud_print/service/win/service_listener.cc

@@ -95,8 +95,7 @@ void ServiceListener::Connect() {

// This process never sends or receives brokered attachments, so there's no

// need for an attachment broker.

channel_ =

- IPC::Channel::CreateClient(IPC::ChannelHandle(handle.Get()), this,

- nullptr /* attachment_broker */);

+ IPC::Channel::CreateClient(IPC::ChannelHandle(handle.Get()), this);

channel_->Connect();

} else {

ipc_thread_->message_loop()->PostDelayedTask(

« no previous file with comments | « no previous file | content/test/render_thread_impl_browser_test_ipc_helper.cc » ('j') | no next file with comments »