Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: ipc/ipc_channel_common.cc

Issue 1354973006: ipc: Remove unnecessary attachment broker plumbing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile errors. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/ipc_channel.h ('k') | ipc/ipc_channel_factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ipc/ipc_channel.h" 5 #include "ipc/ipc_channel.h"
6 6
7 namespace IPC { 7 namespace IPC {
8 8
9 static Channel::MessageVerifier g_message_verifier = nullptr; 9 static Channel::MessageVerifier g_message_verifier = nullptr;
10 10
11 // static 11 // static
12 scoped_ptr<Channel> Channel::CreateClient( 12 scoped_ptr<Channel> Channel::CreateClient(
13 const IPC::ChannelHandle& channel_handle, 13 const IPC::ChannelHandle& channel_handle,
14 Listener* listener, 14 Listener* listener) {
15 AttachmentBroker* broker) { 15 return Channel::Create(channel_handle, Channel::MODE_CLIENT, listener);
16 return Channel::Create(channel_handle, Channel::MODE_CLIENT, listener,
17 broker);
18 } 16 }
19 17
20 // static 18 // static
21 scoped_ptr<Channel> Channel::CreateNamedServer( 19 scoped_ptr<Channel> Channel::CreateNamedServer(
22 const IPC::ChannelHandle& channel_handle, 20 const IPC::ChannelHandle& channel_handle,
23 Listener* listener, 21 Listener* listener) {
24 AttachmentBroker* broker) { 22 return Channel::Create(channel_handle, Channel::MODE_NAMED_SERVER, listener);
25 return Channel::Create(channel_handle, Channel::MODE_NAMED_SERVER, listener,
26 broker);
27 } 23 }
28 24
29 // static 25 // static
30 scoped_ptr<Channel> Channel::CreateNamedClient( 26 scoped_ptr<Channel> Channel::CreateNamedClient(
31 const IPC::ChannelHandle& channel_handle, 27 const IPC::ChannelHandle& channel_handle,
32 Listener* listener, 28 Listener* listener) {
33 AttachmentBroker* broker) { 29 return Channel::Create(channel_handle, Channel::MODE_NAMED_CLIENT, listener);
34 return Channel::Create(channel_handle, Channel::MODE_NAMED_CLIENT, listener,
35 broker);
36 } 30 }
37 31
38 #if defined(OS_POSIX) 32 #if defined(OS_POSIX)
39 // static 33 // static
40 scoped_ptr<Channel> Channel::CreateOpenNamedServer( 34 scoped_ptr<Channel> Channel::CreateOpenNamedServer(
41 const IPC::ChannelHandle& channel_handle, 35 const IPC::ChannelHandle& channel_handle,
42 Listener* listener, 36 Listener* listener) {
43 AttachmentBroker* broker) {
44 return Channel::Create(channel_handle, Channel::MODE_OPEN_NAMED_SERVER, 37 return Channel::Create(channel_handle, Channel::MODE_OPEN_NAMED_SERVER,
45 listener, broker); 38 listener);
46 } 39 }
47 #endif 40 #endif
48 41
49 // static 42 // static
50 scoped_ptr<Channel> Channel::CreateServer( 43 scoped_ptr<Channel> Channel::CreateServer(
51 const IPC::ChannelHandle& channel_handle, 44 const IPC::ChannelHandle& channel_handle,
52 Listener* listener, 45 Listener* listener) {
53 AttachmentBroker* broker) { 46 return Channel::Create(channel_handle, Channel::MODE_SERVER, listener);
54 return Channel::Create(channel_handle, Channel::MODE_SERVER, listener,
55 broker);
56 } 47 }
57 48
58 Channel::~Channel() { 49 Channel::~Channel() {
59 } 50 }
60 51
61 // static 52 // static
62 void Channel::SetMessageVerifier(MessageVerifier verifier) { 53 void Channel::SetMessageVerifier(MessageVerifier verifier) {
63 g_message_verifier = verifier; 54 g_message_verifier = verifier;
64 } 55 }
65 56
66 // static 57 // static
67 Channel::MessageVerifier Channel::GetMessageVerifier() { 58 Channel::MessageVerifier Channel::GetMessageVerifier() {
68 return g_message_verifier; 59 return g_message_verifier;
69 } 60 }
70 61
71 bool Channel::IsSendThreadSafe() const { 62 bool Channel::IsSendThreadSafe() const {
72 return false; 63 return false;
73 } 64 }
74 65
75 } // namespace IPC 66 } // namespace IPC
76 67
OLDNEW
« no previous file with comments | « ipc/ipc_channel.h ('k') | ipc/ipc_channel_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698