Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: ipc/ipc_channel.h

Issue 1354973006: ipc: Remove unnecessary attachment broker plumbing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile errors. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/attachment_broker_privileged_win_unittest.cc ('k') | ipc/ipc_channel_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel.h
diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h
index 06555d333de03dc565a8bed0d25a75461577eca2..7aa3ab0654dc7d4663e4555431c768bba9fcb201 100644
--- a/ipc/ipc_channel.h
+++ b/ipc/ipc_channel.h
@@ -22,7 +22,6 @@
namespace IPC {
-class AttachmentBroker;
class Listener;
//------------------------------------------------------------------------------
@@ -120,22 +119,13 @@ class IPC_EXPORT Channel : public Endpoint {
// Each mode has its own Create*() API to create the Channel object.
//
// TODO(morrita): Replace CreateByModeForProxy() with one of above Create*().
- //
- // TODO(erikchen): Remove default parameter for |broker|. It exists only to
- // make the upcoming refactor decomposable into smaller CLs.
- // http://crbug.com/493414.
static scoped_ptr<Channel> Create(const IPC::ChannelHandle& channel_handle,
Mode mode,
- Listener* listener,
- AttachmentBroker* broker = nullptr);
+ Listener* listener);
- // TODO(erikchen): Remove default parameter for |broker|. It exists only to
- // make the upcoming refactor decomposable into smaller CLs.
- // http://crbug.com/493414.
static scoped_ptr<Channel> CreateClient(
const IPC::ChannelHandle& channel_handle,
- Listener* listener,
- AttachmentBroker* broker = nullptr);
+ Listener* listener);
// Channels on Windows are named by default and accessible from other
// processes. On POSIX channels are anonymous by default and not accessible
@@ -144,28 +134,21 @@ class IPC_EXPORT Channel : public Endpoint {
// MODE_NAMED_CLIENT is equivalent to MODE_CLIENT.
static scoped_ptr<Channel> CreateNamedServer(
const IPC::ChannelHandle& channel_handle,
- Listener* listener,
- AttachmentBroker* broker);
+ Listener* listener);
static scoped_ptr<Channel> CreateNamedClient(
const IPC::ChannelHandle& channel_handle,
- Listener* listener,
- AttachmentBroker* broker);
+ Listener* listener);
#if defined(OS_POSIX)
// An "open" named server accepts connections from ANY client.
// The caller must then implement their own access-control based on the
// client process' user Id.
static scoped_ptr<Channel> CreateOpenNamedServer(
const IPC::ChannelHandle& channel_handle,
- Listener* listener,
- AttachmentBroker* broker);
+ Listener* listener);
#endif
- // TODO(erikchen): Remove default parameter for |broker|. It exists only to
- // make the upcoming refactor decomposable into smaller CLs.
- // http://crbug.com/493414.
static scoped_ptr<Channel> CreateServer(
const IPC::ChannelHandle& channel_handle,
- Listener* listener,
- AttachmentBroker* broker = nullptr);
+ Listener* listener);
~Channel() override;
« no previous file with comments | « ipc/attachment_broker_privileged_win_unittest.cc ('k') | ipc/ipc_channel_common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698