DevTools: cleanup timeline concise record details generation

DevTools: cleanup timeline concise record details generation

- never expose timer/animation frames ids, they're not meaningful most
    of the time, fallback to script URLs instead;
- expose short rather than full URLs;
- add test coverage.

BUG=

Committed: https://crrev.com/414e603979c23cc66e38e778ba9ecc10b1b987fc
Cr-Commit-Position: refs/heads/master@{#350413}

[caseq, 2015-09-18 22:28:57]

caseq@chromium.org changed reviewers:
+ alph@chromium.org, yurys@chromium.org

[yurys, 2015-09-21 18:49:33]

https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
File LayoutTests/inspector/tracing/timeline-injected-script-eval-expected.txt
(right):

https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
LayoutTests/inspector/tracing/timeline-injected-script-eval-expected.txt:19:
Text details for FunctionCall: VM693:1
This is bound to flake.

https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
File LayoutTests/inspector/tracing/timeline-parse-html.html (right):

https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
LayoutTests/inspector/tracing/timeline-parse-html.html:19: if
(!window.testRunner)
Please revert this.

https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
File LayoutTests/inspector/tracing/timeline-receive-response-event.html (right):

https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
LayoutTests/inspector/tracing/timeline-receive-response-event.html:29: var
typesToDump = new Set(["ResourceSendRequest", "ResourceReceiveResponse",
"ResourceReceivedData", "ResourceFinish", "EventDispatch", "FunctionCall"]);
Can we reference constants from TimelineModel.js instead?

https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
File LayoutTests/inspector/tracing/timeline-time-stamp.html (right):

https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
LayoutTests/inspector/tracing/timeline-time-stamp.html:17: if
(!window.testRunner)
Revert?

[caseq, 2015-09-22 00:59:25]

Patchset #3 (id:40001) has been deleted

[caseq, 2015-09-22 00:59:33]

Patchset #3 (id:60001) has been deleted

[caseq, 2015-09-22 01:01:38]

ptal

On 2015/09/21 18:49:33, yurys wrote:
>
https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
> File LayoutTests/inspector/tracing/timeline-injected-script-eval-expected.txt
> (right):
> 
>
https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
> LayoutTests/inspector/tracing/timeline-injected-script-eval-expected.txt:19:
> Text details for FunctionCall: VM693:1
> This is bound to flake.

Yup, thanks for spotting! Fixing this by omitting text details for noname
scripts, since this is not very informative anyway.

>
https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
> File LayoutTests/inspector/tracing/timeline-parse-html.html (right):
> 
>
https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
> LayoutTests/inspector/tracing/timeline-parse-html.html:19: if
> (!window.testRunner)
> Please revert this.

As discussed offline, this is on purpose -- we aim at making tests suitable for
manual testing in browser, not just in content shell's DRT mode.

>
https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
> File LayoutTests/inspector/tracing/timeline-receive-response-event.html
(right):
> 
>
https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
> LayoutTests/inspector/tracing/timeline-receive-response-event.html:29: var
> typesToDump = new Set(["ResourceSendRequest", "ResourceReceiveResponse",
> "ResourceReceivedData", "ResourceFinish", "EventDispatch", "FunctionCall"]);
> Can we reference constants from TimelineModel.js instead?

Done.

>
https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
> File LayoutTests/inspector/tracing/timeline-time-stamp.html (right):
> 
>
https://codereview.chromium.org/1353653003/diff/20001/LayoutTests/inspector/t...
> LayoutTests/inspector/tracing/timeline-time-stamp.html:17: if
> (!window.testRunner)
> Revert?

See above.

[yurys, 2015-09-23 20:44:19]

https://codereview.chromium.org/1353653003/diff/80001/Source/devtools/front_e...
File Source/devtools/front_end/timeline/TimelineUIUtils.js (right):

https://codereview.chromium.org/1353653003/diff/80001/Source/devtools/front_e...
Source/devtools/front_end/timeline/TimelineUIUtils.js:295: // Omit internally
generated script names.
eval'd scripts will also miss scriptName but I believe we still want to be able
to navigate to them.

[yurys, 2015-09-23 20:47:29]

lgtm

[caseq, 2015-09-23 20:52:51]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2015-09-23 20:53:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353653003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353653003/80001

[commit-bot: I haz the power, 2015-09-23 20:53:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 20:53:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2015-09-23 21:00:09]

The CQ bit was checked by caseq@chromium.org

[caseq, 2015-09-23 21:00:09]

The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/1353653003/#ps100001
(title: "re-uploading after blink repo merge")

[commit-bot: I haz the power, 2015-09-23 21:00:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353653003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353653003/100001

[commit-bot: I haz the power, 2015-09-23 21:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 21:53:46]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[caseq, 2015-09-23 21:54:41]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2015-09-23 21:55:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353653003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353653003/100001

[commit-bot: I haz the power, 2015-09-23 22:11:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 22:11:04]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2015-09-23 23:15:57]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2015-09-23 23:17:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1353653003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1353653003/100001

[commit-bot: I haz the power, 2015-09-24 00:24:45]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-09-24 00:35:23]

Patchset 4 (id:??) landed as
https://crrev.com/414e603979c23cc66e38e778ba9ecc10b1b987fc
Cr-Commit-Position: refs/heads/master@{#350413}

[paulirish, 2015-09-24 04:42:46]

https://codereview.chromium.org/1353653003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
(right):

https://codereview.chromium.org/1353653003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:320:
detailsText = detailsText = WebInspector.displayNameForURL(url) + ":" +
eventData["lineNumber"];
double double?