third_party/WebKit/LayoutTests/inspector/tracing/timeline-animation-frame.html - Issue 1353653003: DevTools: cleanup timeline concise record details generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-animation-frame.html

Issue 1353653003: DevTools: cleanup timeline concise record details generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: re-uploading after blink repo merge Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/hit-test-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-animation-frame-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-animation-frame.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-animation-frame.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-animation-frame.html

index ddfa1f3335f662d9298a988e5ccef935109542b5..9f010372604ec3cac42b8daee5eb9b1193321480 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-animation-frame.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-animation-frame.html

@@ -11,7 +11,8 @@ function performActions(callback)

function animationFrameCallback()

{

window.cancelAnimationFrame(requestId);

- callback();

+ if (callback)

+ callback();

}

@@ -21,9 +22,9 @@ function test()

function finish()

{

- InspectorTest.printTimelineRecords("RequestAnimationFrame");

- InspectorTest.printTimelineRecords("FireAnimationFrame");

- InspectorTest.printTimelineRecords("CancelAnimationFrame");

+ InspectorTest.printTimelineRecordsWithDetails("RequestAnimationFrame");

+ InspectorTest.printTimelineRecordsWithDetails("FireAnimationFrame");

+ InspectorTest.printTimelineRecordsWithDetails("CancelAnimationFrame");

InspectorTest.completeTest();

}